GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126835: Fix `optimize_if_const_subscr` refleaks by WolframAlph · Pull Request #129634 · python/cpython

Conversation

@WolframAlph

@WolframAlph WolframAlph commented Feb 4, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Move const folding to the peephole optimizer #126835

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@WolframAlph
fix optimize_if_const_subscr refleaks
283fd58
@WolframAlph
WolframAlph requested review from iritkatriel and markshannon as code owners February 4, 2025 09:45
@bedevere-app bedevere-app Bot added the awaiting review label Feb 4, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 4, 2025
Move const folding to the peephole optimizer #126835
Open
@Eclips4 Eclips4 added the skip news label Feb 4, 2025
WolframAlph
WolframAlph commented Feb 4, 2025
View reviewed changes
Comment thread Python/flowgraph.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4

Eclips4 commented Feb 4, 2025

Copy link
Copy Markdown
Member

Results from the local run of the test suite in huntrefleaks mode:

442 tests OK.

Total duration: 18 min 38 sec
Total tests: run=43,904 skipped=2,554
Total test files: run=476/484 skipped=34 resource_denied=8
Result: SUCCESS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@WolframAlph
decref even if fail
224c7a6
Eclips4
Eclips4 approved these changes Feb 4, 2025
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for a quick fix!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
WolframAlph and srinivasreddy reacted with heart emoji
All reactions
  • ❤️ 2 reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 4, 2025
@Eclips4
Eclips4 enabled auto-merge (squash) February 4, 2025 10:16
@picnixz picnixz mentioned this pull request Feb 4, 2025
test_peepholers leaks references (main branch) #129635
Closed
@WolframAlph WolframAlph mentioned this pull request Feb 4, 2025
gh-126835: Move constant subscript folding to CFG #129568
Merged
@Eclips4
Eclips4 merged commit d3c54f3 into python:main Feb 4, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 4, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@WolframAlph @srinivasreddy
pythongh-126835: Fix reference leak in `Python/flowgrapc.::optimize_i…
054fcc6 
…f_const_subscr` (python#129634)
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
@WolframAlph @cmaloney
pythongh-126835: Fix reference leak in `Python/flowgrapc.::optimize_i…
b01783a 
…f_const_subscr` (python#129634)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@Eclips4 Eclips4 Eclips4 approved these changes
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@WolframAlph @Eclips4 @iritkatriel @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.