GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117657: Fix data race in new_reference for free-threaded build by wrongnull · Pull Request #129665 · python/cpython

Conversation

@wrongnull

@wrongnull wrongnull commented Feb 4, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@wrongnull
fix the race
7cb877b
@bedevere-app bedevere-app Bot added the awaiting review label Feb 4, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 4, 2025
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
@wrongnull
wrongnull marked this pull request as draft February 4, 2025 18:05
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 4, 2025
@wrongnull
wrongnull marked this pull request as ready for review February 4, 2025 18:37
@bedevere-app bedevere-app Bot added the awaiting review label Feb 4, 2025
@Eclips4 Eclips4 added the skip news label Feb 4, 2025
@Eclips4
Eclips4 requested a review from colesbury February 4, 2025 18:39
colesbury
colesbury reviewed Feb 4, 2025
View reviewed changes
Comment thread Objects/object.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@wrongnull
use _Py_THREAD_SANITIZER macro for performance reasons
d7cb09f
@colesbury
colesbury self-requested a review February 6, 2025 18:56
colesbury
colesbury approved these changes Feb 6, 2025
View reviewed changes

@colesbury colesbury left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
wrongnull reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 6, 2025
@colesbury
colesbury merged commit 365cf5f into python:main Feb 6, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 6, 2025
@colesbury colesbury added the topic-free-threading label Feb 6, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@wrongnull @srinivasreddy
pythongh-117657: Fix data race in new_reference for free threaded b…
9411590 
…uild (pythongh-129665)
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
@wrongnull @cmaloney
pythongh-117657: Fix data race in new_reference for free threaded b…
bf52dc7 
…uild (pythongh-129665)
@colesbury colesbury mentioned this pull request Mar 24, 2025
Data race between _Py_NewReference and _Py_IsOwnedByCurrentThread under free-threading #131680
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@wrongnull @colesbury @Eclips4
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.