GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129005: Update _pyio.BytesIO to use bytearray.resize on write by cmaloney · Pull Request #129702 · python/cpython

Conversation

@cmaloney

@cmaloney cmaloney commented Feb 5, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

bytearray.resize() does the nulling if needed. Including the new write length, n, since doing two resizes in a row to do the memcpy doesn't seem worthwhile.

I think this can skip news as it's internal implementation change with no visible external changes, should just be faster.

  • Issue: Reduce copies when reading files in pyio, match behavior of _io #129005

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cmaloney
pythongh-129005: Update _pyio.BytesIO to use bytearray.resize on write
63795c8
@bedevere-app bedevere-app Bot added the awaiting review label Feb 5, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 5, 2025
Reduce copies when reading files in pyio, match behavior of _io #129005
Closed
@vstinner vstinner added the skip news label Feb 5, 2025
vstinner
vstinner reviewed Feb 5, 2025
View reviewed changes
Comment thread Lib/_pyio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@cmaloney @vstinner
Update Lib/_pyio.py
7d30781 
Co-authored-by: Victor Stinner <[email protected]>
vstinner
vstinner reviewed Feb 5, 2025
View reviewed changes
Comment thread Lib/_pyio.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@cmaloney
Update comment
e192903
vstinner
vstinner approved these changes Feb 6, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cmaloney reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 6, 2025
@vstinner
vstinner enabled auto-merge (squash) February 6, 2025 09:56
@vstinner
vstinner merged commit 052ca8f into python:main Feb 6, 2025
@cmaloney
cmaloney deleted the cmaloney/pyio_readinto_resize branch February 6, 2025 17:46
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@cmaloney @vstinner @srinivasreddy
pythongh-129005: Update _pyio.BytesIO to use bytearray.resize on write (
75ef9b0 
python#129702)

Co-authored-by: Victor Stinner <[email protected]>
cmaloney added a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
@cmaloney @vstinner
pythongh-129005: Update _pyio.BytesIO to use bytearray.resize on write (
ef214e3 
python#129702)

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@cmaloney @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.