GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-117657: Skip tests that may cause stack overflows under TSan by colesbury · Pull Request #129751 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Feb 6, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

These tests crash under TSan due to stack overflows. Just skip them if TSan is enabled.

  • Issue: Make TSAN tests pass with the GIL disabled in free-threaded builds #117657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-117657: Skip tests that may cause stack overflows under TSan
93800cb 
These tests crash under TSan due to stack overflows. Just skip them if
TSan is enabled.
@colesbury colesbury added skip news topic-free-threading labels Feb 6, 2025
@colesbury
colesbury requested a review from mpage February 6, 2025 20:48
@colesbury
colesbury requested a review from rhettinger as a code owner February 6, 2025 20:48
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Feb 6, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 6, 2025
Make TSAN tests pass with the GIL disabled in free-threaded builds #117657
Closed
mpage
mpage approved these changes Feb 6, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 6, 2025
@colesbury
colesbury merged commit 4e3330f into python:main Feb 6, 2025
@colesbury
colesbury deleted the gh-117657-stack-overflow branch February 6, 2025 22:03
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 6, 2025
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this pull request Feb 7, 2025
@colesbury @srinivasreddy
pythongh-117657: Skip tests that may cause stack overflows under TSan (…
60c6767 
…python#129751)

These tests crash under TSan due to stack overflows. Just skip them if
TSan is enabled.
cmaloney pushed a commit to cmaloney/cpython that referenced this pull request Feb 8, 2025
@colesbury @cmaloney
pythongh-117657: Skip tests that may cause stack overflows under TSan (…
5d33246 
…python#129751)

These tests crash under TSan due to stack overflows. Just skip them if
TSan is enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpage mpage mpage approved these changes
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @mpage
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.