GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97850: Update the deprecation warning of `importlib.abc.Loader.load_module` by tomasr8 · Pull Request #129855 · python/cpython

Conversation

@tomasr8

@tomasr8 tomasr8 commented Feb 8, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The deprecation warning was added in 3.10 by #23469.

The warning currently states that the removal is planned for 3.12. I suggest we update it to say 3.15 which, following the 5 releases rule, is the earliest release in which the methods can be removed (whether or not we'll actually be able to do that is another question, but let's at least keep the warnings up to date).

Related discussion: #97850 (comment) , #97850 (comment)

  • Issue: Meta issue for cleaning up import system cruft #97850

📚 Documentation preview 📚: https://cpython-previews--129855.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
tomasr8 added 3 commits February 8, 2025 14:49
@tomasr8
Update Loader.load_module deprecation message
1acb61b
@tomasr8
Update docs
ec64a24
@tomasr8
Add news entry
6653b70
@tomasr8
tomasr8 requested review from brettcannon, ericsnowcurrently, ncoghlan and warsaw as code owners February 8, 2025 14:27
@bedevere-app bedevere-app Bot added the awaiting review label Feb 8, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 8, 2025
Meta issue for cleaning up import system cruft #97850
Open
25 of 31 tasks
brettcannon
brettcannon approved these changes Feb 11, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 11, 2025
@brettcannon brettcannon added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Feb 11, 2025
@brettcannon
brettcannon merged commit aa81a6f into python:main Feb 11, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 11, 2025

Copy link
Copy Markdown

Thanks @tomasr8 for the PR, and @brettcannon for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 11, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 11, 2025
@tomasr8 @miss-islington
pythongh-97850: Update the deprecation warning of `importlib.abc.Load…
7d76b88 
…er.load_module` (pythonGH-129855)

(cherry picked from commit aa81a6f)

Co-authored-by: Tomas R. <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 11, 2025

Copy link
Copy Markdown

GH-130013 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 11, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 11, 2025

Copy link
Copy Markdown

Sorry, @tomasr8 and @brettcannon, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker aa81a6f6e4f265565da9781d0bf95c7d16ddd961 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned brettcannon Feb 11, 2025
@tomasr8

tomasr8 commented Feb 11, 2025

Copy link
Copy Markdown
Member Author

I can look into the 3.12 backport later :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brettcannon pushed a commit that referenced this pull request Feb 11, 2025
@miss-islington @tomasr8
[3.13] gh-97850: Update the deprecation warning of `importlib.abc.Loa…
e5c522e 
…der.load_module` (GH-129855) (GH-130013)

gh-97850: Update the deprecation warning of `importlib.abc.Loader.load_module` (GH-129855)
(cherry picked from commit aa81a6f)

Co-authored-by: Tomas R <[email protected]>
@Wulian233 Wulian233 mentioned this pull request Feb 11, 2025
gh-125746: Delay deprecated zipimport.zipimporter.load_module removal time to 3.15 #125748
Merged
@bedevere-app

bedevere-app Bot commented Feb 11, 2025

Copy link
Copy Markdown

GH-130017 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 11, 2025
@tomasr8
tomasr8 deleted the importlib-module-shim branch February 11, 2025 20:48
brettcannon pushed a commit that referenced this pull request Feb 11, 2025
@tomasr8
[3.12] gh-97850: Update the deprecation warning of `importlib.abc.Loa…
96a6ee0 
…der.load_module` (GH-129855) (GH-130017)

(cherry picked from commit aa81a6f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brettcannon brettcannon brettcannon approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brettcannon brettcannon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tomasr8 @brettcannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.