GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — reinit the TLS before anything else by benjaminp · Pull Request #130 · python/cpython

Conversation

@benjaminp

@benjaminp benjaminp commented Feb 16, 2017

Copy link
Copy Markdown
Contributor

PyEval_ReInitThread can run arbitrary Python code, which really ought to have
the TLS properly initialized. This essentially backports the Python 3 ordering.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benjaminp
reinit the TLS before anything else
db44b88 
PyEval_ReInitThread can run arbitrary Python code, which really ought to have
the TLS initialized.
berkerpeksag
berkerpeksag approved these changes Feb 21, 2017
View reviewed changes

@berkerpeksag berkerpeksag left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not really qualified to review this, but... since you're the RM of 2.7 and this is a backport from Python 3 here's my +1 :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@benjaminp
benjaminp merged commit d9a7574 into 2.7 Feb 21, 2017
@berkerpeksag
berkerpeksag deleted the benjamin-reinit-tls branch February 21, 2017 07:53
akruis referenced this pull request in stackless-dev/stackless Sep 5, 2017
Anselm Kruis
merge 3.4-slp (Stackless #130, fix exhausted generator pickling)
3269354
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
hg
Issue python#130: fix pickling of exhausted generator objects
9fbbf8b 
Pickling of an exhausted generator no longer causes a segmentation fault.

https://bitbucket.org/stackless-dev/stackless/issues/130
(grafted from b86bda31f4e3372bbde61179cc890af24d83ae71)
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Anselm Kruis
merge 3.3-slp (Stackless python#130, fix exhausted generator pickling
895f2c6
akruis pushed a commit to akruis/cpython that referenced this pull request Nov 7, 2017
Anselm Kruis
merge 3.5-slp (Stackless python#130, fix exhausted generator pickling)
c615848
akruis pushed a commit to akruis/cpython that referenced this pull request Mar 25, 2018
Anselm Kruis
merge 3.6-slp (Stackless python#130, fix exhausted generator pickling)
8e11bad
pablogsal referenced this pull request in pablogsal/cpython Aug 13, 2022
@lysnikolaou
Add vm target to pegen script to generate the vm parser (#130)
a9a4115
@pablogsal pablogsal mentioned this pull request Aug 13, 2022
bpo-40222: Mark exception table function in the dis module as private #95960
Closed
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
heap-use-after-free in _PyFunction_LookupByVersion #108253
Closed
This was referenced Feb 11, 2025
segmentfault when pip installing setuptools #129992
Closed
segmentfault when pip installing setuptools #129993
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@benjaminp @berkerpeksag
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.