GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130025: Correct handling of symlinks during iOS testbed framework installation. by freakboy3742 · Pull Request #130026 · python/cpython

Conversation

@freakboy3742

@freakboy3742 freakboy3742 commented Feb 12, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Corrects the handling of symlinks when the iOS testbed clones a new project:

  1. Locations to source are resolved before use in the clone call.
  2. Use of resolve is dropped from the evaluation of xc_framework_path and sim_framework_path. If the XCframework/framework is a symlink, we don't want to resolve the symlink to it's final location (as it may not exist)
  3. If the XCframework on sim framework doesn't exist at all, the unlink is now a no-op.
  4. If no framework is specified, but the existing framework is a relative symlink, it is re-written relative to the new framework location (and similarly for the simulator framework).
  • Issue: iOS testbed clone breaks on some symlinks #130025

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@freakboy3742
Correct handling of symlinks during iOS testbed framework installation.
5ffdbf6
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 12, 2025
@freakboy3742 freakboy3742 changed the title Correct handling of symlinks during iOS testbed framework installation. gh-130025: Correct handling of symlinks during iOS testbed framework installation. Feb 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 12, 2025
iOS testbed clone breaks on some symlinks #130025
Closed
@freakboy3742

freakboy3742 commented Feb 12, 2025

Copy link
Copy Markdown
Contributor Author

This needs to be tested on the iOS buildbot, but the buildbot is currently offline for maintenance.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742 freakboy3742 added 3.13 only security fixes OS-ios 3.14 bugs and security fixes needs backport to 3.13 only security fixes labels Feb 12, 2025
@picnixz picnixz removed 3.13 only security fixes 3.14 bugs and security fixes labels Feb 12, 2025
@freakboy3742

freakboy3742 commented Feb 13, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot iOS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Feb 13, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 5ffdbf6 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742
freakboy3742 requested a review from ned-deily February 13, 2025 03:02
@freakboy3742

freakboy3742 commented Feb 13, 2025

Copy link
Copy Markdown
Contributor Author

Buildbot is back online (for now at least... there will likely be some more maintenance in the near future) - but I can at least confirm the testbed still works in CI with this change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ned-deily
ned-deily approved these changes Feb 13, 2025
View reviewed changes

@ned-deily ned-deily left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (without actually testing)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 13, 2025
@freakboy3742
freakboy3742 merged commit 625470a into python:main Feb 13, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 13, 2025

Copy link
Copy Markdown

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 13, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 13, 2025
@freakboy3742 @miss-islington
pythongh-130025: Correct handling of symlinks during iOS testbed fram…
3cf11f4 
…ework installation. (pythonGH-130026)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 13, 2025

Copy link
Copy Markdown

GH-130073 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 13, 2025
@freakboy3742
freakboy3742 deleted the ios-testbed-symlink branch February 13, 2025 06:07
freakboy3742 added a commit that referenced this pull request Feb 13, 2025
@miss-islington @freakboy3742
[3.13] gh-130025: Correct handling of symlinks during iOS testbed fra…
32158ea 
…mework installation. (GH-130026) (#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
@freakboy3742 freakboy3742 mentioned this pull request Feb 13, 2025
Bump patch to Python3.14.0a5 beeware/Python-Apple-support#247
Merged
4 tasks done
freakboy3742 added a commit to beeware/Python-Apple-support that referenced this pull request Feb 13, 2025
@freakboy3742
Bump patch to Python3.14.0a5. (#247)
a2c04c3 
Update Python to 3.14.0a5.

Also includes:

* python/cpython#130026 testbed symlink handling
* LibFFI 3.4.7
* OpenSSL 3.0.16
* XZ 5.6.4
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 18, 2025
@freakboy3742
pythongh-130025: Correct handling of symlinks during iOS testbed fram…
3634b21 
…ework installation. (python#130026)

Correct handling of symlinks during iOS testbed framework installation.
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 18, 2025
@miss-islington @freakboy3742
[3.13] pythongh-130025: Correct handling of symlinks during iOS testb…
f1986e1 
…ed framework installation. (pythonGH-130026) (python#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
@hugovk

hugovk commented Feb 28, 2025

Copy link
Copy Markdown
Member

@python/organization-owners Please block @mfxrhxn for abuse (see also #128450 (review)).

I also reported them to GitHub.
JacobCoffee reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Mar 16, 2025
@miss-islington @freakboy3742
[3.11] pythongh-130025: Correct handling of symlinks during iOS testb…
a5768e5 
…ed framework installation. (pythonGH-130026) (python#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Mar 16, 2025
@miss-islington @freakboy3742
[3.10] pythongh-130025: Correct handling of symlinks during iOS testb…
037946d 
…ed framework installation. (pythonGH-130026) (python#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Mar 16, 2025
@miss-islington @freakboy3742
[3.9] pythongh-130025: Correct handling of symlinks during iOS testbe…
ed3490f 
…d framework installation. (pythonGH-130026) (python#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 3, 2026
@miss-islington @freakboy3742
[3.10] pythongh-130025: Correct handling of symlinks during iOS testb…
2af463f 
…ed framework installation. (pythonGH-130026) (python#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 3, 2026
@miss-islington @freakboy3742
[3.11] pythongh-130025: Correct handling of symlinks during iOS testb…
45d8f11 
…ed framework installation. (pythonGH-130026) (python#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 3, 2026
@miss-islington @freakboy3742
[3.12] pythongh-130025: Correct handling of symlinks during iOS testb…
be28464 
…ed framework installation. (pythonGH-130026) (python#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Jun 12, 2026
@miss-islington @freakboy3742
[3.11] pythongh-130025: Correct handling of symlinks during iOS testb…
71192b5 
…ed framework installation. (pythonGH-130026) (python#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Jun 12, 2026
@miss-islington @freakboy3742
[3.12] pythongh-130025: Correct handling of symlinks during iOS testb…
962edd5 
…ed framework installation. (pythonGH-130026) (python#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Oct 2, 2026
@miss-islington @freakboy3742
[3.12] pythongh-130025: Correct handling of symlinks during iOS testb…
c08bbf2 
…ed framework installation. (pythonGH-130026) (python#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Oct 2, 2026
@miss-islington @freakboy3742
[3.11] pythongh-130025: Correct handling of symlinks during iOS testb…
3481ac0 
…ed framework installation. (pythonGH-130026) (python#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Oct 12, 2026
@miss-islington @freakboy3742
[3.12] pythongh-130025: Correct handling of symlinks during iOS testb…
2511951 
…ed framework installation. (pythonGH-130026) (python#130073)

Correct handling of symlinks during iOS testbed framework installation.
(cherry picked from commit 625470a)

Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@freakboy3742 @bedevere-bot @hugovk @ned-deily @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.