GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-118761: Revert "Improve import time of `subprocess` (GH-129427)" (GH-130201) by miss-islington · Pull Request #130205 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Feb 16, 2025

Copy link
Copy Markdown
Contributor
  • Revert "Improve import time of various stdlib modules #118761: Improve import time of subprocess (gh-118761: Improve import time of subprocess #129427)"

This reverts commit 49f2465.
Also known as f502c8f in 3.13 (PR GH-129447)
Also known as f65aa0d in 3.12 (PR GH-129448)

This caused bugs in the __del__ finalizer:
#118761 (comment)

(cherry picked from commit ae30646)

Co-authored-by: Gregory P. Smith [email protected]
Co-authored-by: Bénédikt Tran [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead @picnixz @miss-islington
pythongh-118761: Revert "Improve import time of subprocess (pythonG…
7147657 
…H-129427)" (pythonGH-130201)

* Revert "pythongh-118761: Improve import time of `subprocess` (pythonGH-129427)"

This reverts commit 49f2465.
Also known as f502c8f in 3.13 (PR pythonGH-129447)
Also known as f65aa0d in 3.12 (PR pythonGH-129448)

This caused bugs in the `__del__` finalizer:
 python#118761 (comment)

---------
(cherry picked from commit ae30646)

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@miss-islington
miss-islington requested a review from gpshead as a code owner February 16, 2025 18:40
@bedevere-app bedevere-app Bot mentioned this pull request Feb 16, 2025
gh-118761: Revert "Improve import time of subprocess (GH-129427)" #130201
Merged
@bedevere-app bedevere-app Bot added the awaiting review label Feb 16, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 16, 2025
Improve import time of various stdlib modules #118761
Closed
@gpshead
gpshead enabled auto-merge (squash) February 16, 2025 18:41
@gpshead
gpshead merged commit 042b492 into python:3.12 Feb 16, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Feb 16, 2025
@miss-islington
miss-islington deleted the backport-ae30646-3.12 branch January 2, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.