GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118761: Revert "Improve import time of `subprocess` (GH-129427)" by gpshead · Pull Request #130201 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Feb 16, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 49f2465.

This caused bugs in the __del__ finalizer:
#118761 (comment)

  • Issue: Improve import time of various stdlib modules #118761

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
Revert "pythongh-118761: Improve import time of subprocess (pythonG…
030d357 
…H-129427)"

This reverts commit 49f2465.

This caused bugs in the `__del__` finalizer:
 python#118761 (comment)
@gpshead gpshead added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Feb 16, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 16, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 16, 2025
Improve import time of various stdlib modules #118761
Closed
@gpshead
NEWS-entry
7e08f86
@gpshead
gpshead enabled auto-merge (squash) February 16, 2025 18:13
@gpshead gpshead self-assigned this Feb 16, 2025
picnixz
picnixz approved these changes Feb 16, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-02-16-10-12-27.gh-issue-118761.TNw5ZC.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 16, 2025
@gpshead @picnixz
Update Misc/NEWS.d/next/Library/2025-02-16-10-12-27.gh-issue-118761.T…
b51da5c 
…Nw5ZC.rst

Co-authored-by: Bénédikt Tran <[email protected]>
@gpshead
gpshead disabled auto-merge February 16, 2025 18:16
@gpshead
gpshead enabled auto-merge (squash) February 16, 2025 18:18
@picnixz

picnixz commented Feb 16, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Actually, shouldn't we remove the previous NEWS entry? I don't know whether it makes sense to have it in the changelog in this case (but if one downloads an exact version they could have it =/)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead

gpshead commented Feb 16, 2025

Copy link
Copy Markdown
Member Author

This has already shipped in releases.
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead

gpshead commented Feb 16, 2025

Copy link
Copy Markdown
Member Author

So the new NEWS entry is a correction for the previous one.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gpshead
gpshead merged commit ae30646 into python:main Feb 16, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 16, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 16, 2025

Copy link
Copy Markdown

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2025
@gpshead @picnixz @miss-islington
pythongh-118761: Revert "Improve import time of subprocess (pythonG…
c1e1e1d 
…H-129427)" (pythonGH-130201)

* Revert "pythongh-118761: Improve import time of `subprocess` (pythonGH-129427)"

This reverts commit 49f2465.
Also known as f502c8f in 3.13 (PR pythonGH-129447)
Also known as f65aa0d in 3.12 (PR pythonGH-129448)

This caused bugs in the `__del__` finalizer:
 python#118761 (comment)

---------
(cherry picked from commit ae30646)

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 16, 2025

Copy link
Copy Markdown

GH-130204 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 16, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 16, 2025
@gpshead @picnixz @miss-islington
pythongh-118761: Revert "Improve import time of subprocess (pythonG…
7147657 
…H-129427)" (pythonGH-130201)

* Revert "pythongh-118761: Improve import time of `subprocess` (pythonGH-129427)"

This reverts commit 49f2465.
Also known as f502c8f in 3.13 (PR pythonGH-129447)
Also known as f65aa0d in 3.12 (PR pythonGH-129448)

This caused bugs in the `__del__` finalizer:
 python#118761 (comment)

---------
(cherry picked from commit ae30646)

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
@gpshead
gpshead deleted the revert-pr129427-subprocess-lazy-imports branch February 16, 2025 18:40
@bedevere-app

bedevere-app Bot commented Feb 16, 2025

Copy link
Copy Markdown

GH-130205 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 16, 2025
gpshead added a commit that referenced this pull request Feb 16, 2025
@miss-islington @gpshead @picnixz
[3.12] gh-118761: Revert "Improve import time of subprocess (GH-129427
042b492 
)" (GH-130201) (#130205)

gh-118761: Revert "Improve import time of `subprocess` (GH-129427)" (GH-130201)

* Revert "gh-118761: Improve import time of `subprocess` (GH-129427)"

This reverts commit 49f2465.
Also known as f502c8f in 3.13 (PR GH-129447)
Also known as f65aa0d in 3.12 (PR GH-129448)

This caused bugs in the `__del__` finalizer:
 #118761 (comment)

---------
(cherry picked from commit ae30646)

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
gpshead added a commit that referenced this pull request Feb 16, 2025
@miss-islington @gpshead @picnixz
[3.13] gh-118761: Revert "Improve import time of subprocess (GH-129427
831695b 
)" (GH-130201) (#130204)

gh-118761: Revert "Improve import time of `subprocess` (GH-129427)" (GH-130201)

* Revert "gh-118761: Improve import time of `subprocess` (GH-129427)"

This reverts commit 49f2465.
Also known as f502c8f in 3.13 (PR GH-129447)
Also known as f65aa0d in 3.12 (PR GH-129448)

This caused bugs in the `__del__` finalizer:
 #118761 (comment)

---------
(cherry picked from commit ae30646)

Co-authored-by: Gregory P. Smith <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@gpshead @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.