GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-127750: Restore inspect and pydoc support of singledispatchmethod by serhiy-storchaka · Pull Request #130309 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Feb 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The code is still flawed, because it does not recognize class and static methods, and the first argument is not removed from the signature of bound methods, but at least it does not worse than in 3.13 and older.

  • Issue: Regression in Django with singledispatchmethod on models #127750

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-127750: Restore inspect and pydoc support of singledispatchm…
5aa8908 
…ethod

The code is still flawed, because it does not recognize class and static
methods, and the first argument is not removed from the signature of
bound methods, but at least it does not worse than in 3.13 and older.
@serhiy-storchaka serhiy-storchaka added the skip news label Feb 19, 2025
@serhiy-storchaka
serhiy-storchaka requested a review from rhettinger as a code owner February 19, 2025 16:28
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 19, 2025
Regression in Django with singledispatchmethod on models #127750
Closed
@rhettinger
rhettinger removed their request for review February 19, 2025 16:33
@serhiy-storchaka

serhiy-storchaka commented Feb 19, 2025

Copy link
Copy Markdown
Member Author

This is a follow up of #130008.

@AA-Turner, I do not know whether this is enough for Sphinx. If not, we will find other solution. Sphinx itself can use a workaround (in can_document_member()) similar to the code used for property, and it may even be more reliable, but we will try to not break old Sphinx.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka merged commit 10b3205 into python:main Feb 20, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 20, 2025
@serhiy-storchaka
serhiy-storchaka deleted the pydoc-singledispatchmethod branch February 20, 2025 09:08
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Feb 20, 2025
@serhiy-storchaka
[3.13] pythongh-127750: Restore inspect and pydoc support of singledi…
e79ded4 
…spatchmethod (pythonGH-130309)

The code is still flawed, because it does not recognize class and static
methods, and the first argument is not removed from the signature of
bound methods, but at least it does not worse than in 3.13 and older.
(cherry picked from commit 10b3205)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Feb 20, 2025
@serhiy-storchaka
[3.13] pythongh-127750: Backport some tests for singledispatchmethod (p…
c6c2d33 
…ythonGH-130309)

(cherry picked from commit 395335d)
(cherry picked from commit 10b3205)
@bedevere-app

bedevere-app Bot commented Feb 20, 2025

Copy link
Copy Markdown

GH-130340 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit that referenced this pull request Feb 20, 2025
@serhiy-storchaka
[3.13] gh-127750: Backport some tests for singledispatchmethod (GH-13…
68c57d6 
…0309) (GH-130340)

(cherry picked from commit 395335d)
(cherry picked from commit 10b3205)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2025
@serhiy-storchaka @miss-islington
[3.13] pythongh-127750: Backport some tests for singledispatchmethod (p…
c160ee6 
…ythonGH-130309) (pythonGH-130340)

(cherry picked from commit 68c57d6)

Co-authored-by: Serhiy Storchaka <[email protected]>
(cherry picked from commit 395335d)
(cherry picked from commit 10b3205)
serhiy-storchaka added a commit that referenced this pull request Feb 20, 2025
@miss-islington @serhiy-storchaka
[3.12] gh-127750: Backport some tests for singledispatchmethod (GH-13…
e63ca56 
…0309) (GH-130340) (GH-130341)

(cherry picked from commit 68c57d6)

(cherry picked from commit 395335d)
(cherry picked from commit 10b3205)

Co-authored-by: Serhiy Storchaka <[email protected]>
@AA-Turner AA-Turner mentioned this pull request Feb 21, 2025
Revert "Mark autodoc singledispatchmethod tests as expected failures" sphinx-doc/sphinx#13381
Merged
johnslavik
johnslavik reviewed Jan 6, 2026
View reviewed changes
Comment thread Lib/test/test_functools.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
johnslavik added a commit to johnslavik/cpython that referenced this pull request Jan 7, 2026
@johnslavik
Fix incorrect regster() calls in `TestSingleDispatch.test_method_si…
a808a1e 
…gnatures`

See python#130309 (comment)
This was referenced Jan 7, 2026
gh-84644: Fix singledispatch annotation parsing #143465
Merged
gh-127750: Fix annotations in singledispatchmethod signature tests #143571
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnslavik johnslavik johnslavik left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @johnslavik
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.