GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130293: Ensure test__colorize will pass on dumb terminals. by freakboy3742 · Pull Request #130333 · python/cpython

Conversation

@freakboy3742

@freakboy3742 freakboy3742 commented Feb 20, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

#129140 slightly modified the logic associated with determining if a console could be colorised. In doing so, the test became sensitive to the test environment's value for the TERM setting.

The iOS 18.2 test simulator sets TERM=dumb in the test environment - this makes some sense, as stdout/stderr handling is performed by the system log, which won't honor tty control sequences.

This appears to be a recent change to iOS; it wasn't true in iOS 17.2. With the recent update to the iOS buildbot, the problem became apparent.

However, the issue isn't iOS specific - it will occur on any machine where TERM=dumb is set in the testing environment. On macOS, I can reproduce the issue with:

TERM=dumb python3.14 -m test test__colorize

This PR ensures that TERM is correctly mocked as part of the colorise test, and normalizes the name used by the iOS Testbed to disable terminal colors.

  • Issue: Colorize tests fail on iOS Xcode 16.2 #130293

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@freakboy3742
Ensure colorize tests will run on dumb terminals.
096c689
@freakboy3742 freakboy3742 added OS-ios needs backport to 3.13 only security fixes labels Feb 20, 2025
@freakboy3742
freakboy3742 requested a review from hugovk as a code owner February 20, 2025 05:43
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 20, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 20, 2025
Colorize tests fail on iOS Xcode 16.2 #130293
Closed
@freakboy3742

freakboy3742 commented Feb 20, 2025

Copy link
Copy Markdown
Contributor Author

!buildbot iOS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Feb 20, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 096c689 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F130333%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Feb 20, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/NEWS.d/next/Tests/2025-02-20-13-39-12.gh-issue-130293.5igSsu.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Tests/2025-02-20-13-39-12.gh-issue-130293.5igSsu.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 20, 2025
@freakboy3742

freakboy3742 commented Feb 20, 2025

Copy link
Copy Markdown
Contributor Author

The iOS buildbot is currently failing because of changes introduced in #130007 and #130318 that are unrelated to this change. The build log show this PR as passing the (previously failed) test__colorize.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@freakboy3742 @hugovk
Apply suggestions from code review
ea913c1 
Co-authored-by: Hugo van Kemenade <[email protected]>
@freakboy3742
freakboy3742 enabled auto-merge (squash) February 20, 2025 06:21
@freakboy3742
freakboy3742 merged commit 1b07006 into python:main Feb 20, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 20, 2025

Copy link
Copy Markdown

Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 20, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 20, 2025
@freakboy3742 @miss-islington
pythongh-130293: Ensure test__colorize will pass on dumb terminals. (p…
b36214b 
…ythonGH-130333)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)
Co-authored-by: Hugo van Kemenade <[email protected]>
(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 20, 2025

Copy link
Copy Markdown

GH-130334 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 20, 2025
@freakboy3742
freakboy3742 deleted the ios-colorize branch February 20, 2025 06:51
freakboy3742 added a commit that referenced this pull request Feb 20, 2025
@miss-islington @freakboy3742
[3.13] gh-130293: Ensure test__colorize will pass on dumb terminals. (G…
439cba7 
…H-130333) (#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Mar 16, 2025
@miss-islington @freakboy3742
[3.11] pythongh-130293: Ensure test__colorize will pass on dumb termi…
d0fb938 
…nals. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Mar 16, 2025
@miss-islington @freakboy3742
[3.10] pythongh-130293: Ensure test__colorize will pass on dumb termi…
7ac097f 
…nals. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Mar 16, 2025
@miss-islington @freakboy3742
[3.9] pythongh-130293: Ensure test__colorize will pass on dumb termin…
ad3288d 
…als. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 3, 2026
@miss-islington @freakboy3742
[3.10] pythongh-130293: Ensure test__colorize will pass on dumb termi…
d01cff9 
…nals. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 3, 2026
@miss-islington @freakboy3742
[3.11] pythongh-130293: Ensure test__colorize will pass on dumb termi…
af931d1 
…nals. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Feb 3, 2026
@miss-islington @freakboy3742
[3.12] pythongh-130293: Ensure test__colorize will pass on dumb termi…
aeac767 
…nals. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Jun 12, 2026
@miss-islington @freakboy3742
[3.11] pythongh-130293: Ensure test__colorize will pass on dumb termi…
fdbaced 
…nals. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Jun 12, 2026
@miss-islington @freakboy3742
[3.12] pythongh-130293: Ensure test__colorize will pass on dumb termi…
a129957 
…nals. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Oct 2, 2026
@miss-islington @freakboy3742
[3.12] pythongh-130293: Ensure test__colorize will pass on dumb termi…
4dfd072 
…nals. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Oct 2, 2026
@miss-islington @freakboy3742
[3.11] pythongh-130293: Ensure test__colorize will pass on dumb termi…
08f0461 
…nals. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Oct 12, 2026
@miss-islington @freakboy3742
[3.12] pythongh-130293: Ensure test__colorize will pass on dumb termi…
7ed064c 
…nals. (pythonGH-130333) (python#130334)

Ensure colorize tests will run on dumb terminals (or environment with TERM=dumb set)

(cherry picked from commit 1b07006)

Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

OS-ios

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@freakboy3742 @bedevere-bot @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.