GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [3.13] gh-130293: Ensure test__colorize will pass on dumb terminals. (GH-130333) by miss-islington · Pull Request #130334 · python/cpython

[3.13] gh-130293: Ensure test__colorize will pass on dumb terminals. (GH-130333) #130334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

freakboy3742 merged 1 commit into python:3.13 from miss-islington:backport-1b07006-3.13

Feb 20, 2025

Uh oh!

There was an error while loading. Please reload this page.

Merged

[3.13] gh-130293: Ensure test__colorize will pass on dumb terminals. (GH-130333) #130334

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

1 commit

Select commit

b36214b

gh-130293: Ensure test__colorize will pass on dumb terminals. (GH-130…

freakboy3742 Feb 20, 2025

File filter

Filter by extension .m (1) .py (1) .rst (1) All 3 file types selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

2 changes: 1 addition & 1 deletion 2 Lib/test/test__colorize.py

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -10,7 +10,7 @@
		@contextlib.contextmanager
		def clear_env():
		with EnvironmentVarGuard() as mock_env:
		for var in "FORCE_COLOR", "NO_COLOR", "PYTHON_COLORS":
		for var in "FORCE_COLOR", "NO_COLOR", "PYTHON_COLORS", "TERM":
		mock_env.unset(var)
		yield mock_env

Expand Down

2 changes: 2 additions & 0 deletions 2 Misc/NEWS.d/next/Tests/2025-02-20-13-39-12.gh-issue-130293.5igSsu.rst

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		The tests of terminal colorization are no longer sensitive to the value of
		the ``TERM`` variable in the testing environment.

2 changes: 1 addition & 1 deletion 2 iOS/testbed/iOSTestbedTests/iOSTestbedTests.m

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -28,7 +28,7 @@ - (void)testPython {
		// Xcode log can't display color. Stdout will report that it is not a
		// TTY.
		setenv("NO_COLOR", "1", true);
		setenv("PY_COLORS", "0", true);
		setenv("PYTHON_COLORS", "0", true);

		// Arguments to pass into the test suite runner.
		// argv[0] must identify the process; any subsequent arg
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.