GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-125722: Increase minimum supported Sphinx to 8.2.0 by AA-Turner · Pull Request #130444 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Feb 22, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Required for #130376, though I don't know how long is prudent to wait following release to increase the minimum requirement.

A

  • Issue: Use the latest Sphinx version #125722

📚 Documentation preview 📚: https://cpython-previews--130444.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
pythonGH-125722: Increase minimum supported Sphinx to 8.2.0
da876af
@AA-Turner AA-Turner added docs Documentation in the Doc dir needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Feb 22, 2025
@AA-Turner
AA-Turner requested a review from hugovk as a code owner February 22, 2025 02:25
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 22, 2025
Use the latest Sphinx version #125722
Closed
@AA-Turner
AA-Turner requested a review from ezio-melotti February 22, 2025 02:25
hugovk
hugovk approved these changes Feb 22, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 22, 2025
encukou
encukou reviewed Feb 24, 2025
View reviewed changes
Comment thread Doc/conf.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Feb 24, 2025

Copy link
Copy Markdown
Member

cc @befeleme FYI
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@befeleme

befeleme commented Feb 25, 2025

Copy link
Copy Markdown
Contributor

Is this change intended only for main/3.14?
In Fedora, we're currently at Sphinx 8.1.3. I could test the 8.2.1 and bring back info whether we're ready for this coming in the next alpha (I see there are two breaking changes comparing to 8.1.x). In general, we tend to wait ~month with Sphinx releases, because of the rest of the docs ecosystem which moves significantly slower.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner

AA-Turner commented Feb 27, 2025

Copy link
Copy Markdown
Member Author

We'll backport it to 3.13 and 3.12 when merged. See the linked issue (#125722) for context and background of why we've changed this policy. Specifically, I took Miro Hrončok's comment in #125722 (comment) as feedback from Fedora.

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@befeleme

befeleme commented Feb 27, 2025

Copy link
Copy Markdown
Contributor

I read the linked discussion and see the reasoning. Given the question is when rather than whether, for the developmental version of Fedora we may be able to build the docs coming in the next Pythons releases.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner merged commit e53d105 into python:main Mar 5, 2025
@miss-islington-app

miss-islington-app Bot commented Mar 5, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 5, 2025
@AA-Turner
AA-Turner deleted the docs/min-sphinx-8-2-0 branch March 5, 2025 00:31
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Mar 5, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 5, 2025
@AA-Turner @miss-islington
pythonGH-125722: Increase minimum supported Sphinx to 8.2.0 (pythonGH…
ff20ada 
…-130444)

(cherry picked from commit e53d105)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 5, 2025

Copy link
Copy Markdown

GH-130858 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 5, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 5, 2025
@AA-Turner @miss-islington
pythonGH-125722: Increase minimum supported Sphinx to 8.2.0 (pythonGH…
f724dec 
…-130444)

(cherry picked from commit e53d105)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 5, 2025

Copy link
Copy Markdown

GH-130859 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 5, 2025
AA-Turner added a commit that referenced this pull request Mar 5, 2025
@miss-islington @AA-Turner
[3.13] GH-125722: Increase minimum supported Sphinx to 8.2.0 (GH-130444…
80cce59 
…) (#130858)

GH-125722: Increase minimum supported Sphinx to 8.2.0 (GH-130444)
(cherry picked from commit e53d105)

Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Mar 5, 2025
@miss-islington @AA-Turner
[3.12] GH-125722: Increase minimum supported Sphinx to 8.2.0 (GH-130444…
919300e 
…) (#130859)

GH-125722: Increase minimum supported Sphinx to 8.2.0 (GH-130444)
(cherry picked from commit e53d105)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@hugovk hugovk hugovk approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AA-Turner @vstinner @befeleme @encukou @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.