GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-121970: Replace `.. coroutine{method,function}` with `:async:` by sobolevn · Pull Request #130448 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Feb 22, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I decided to keep awaitablefunction / awaitablemethod for now, because it is not quite the same as :async:

  • Issue: Improve and reorganise pyspecific #121970

📚 Documentation preview 📚: https://cpython-previews--130448.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-121970: Replace .. coroutine{method,function} with :async:
081cc42
@sobolevn
sobolevn requested review from 1st1, AA-Turner, asvetlov, hugovk, kumaraditya303 and willingc as code owners February 22, 2025 08:10
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 22, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 22, 2025
Improve and reorganise pyspecific #121970
Open
@sobolevn sobolevn added the skip news label Feb 22, 2025
@sobolevn
Fix lint
ada3eef
@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Feb 22, 2025
kumaraditya303
kumaraditya303 reviewed Feb 22, 2025
View reviewed changes
Comment thread Doc/library/asyncio-eventloop.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Fix problems
d3efa3c
@AA-Turner

AA-Turner commented Feb 22, 2025

Copy link
Copy Markdown
Member

I've updated this branch with the changes I had staged locally from my original investigation.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner
AA-Turner approved these changes Feb 22, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 22, 2025
@AA-Turner
AA-Turner enabled auto-merge (squash) February 22, 2025 17:51
@AA-Turner
AA-Turner merged commit 5ec4bf8 into python:main Feb 22, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 22, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 22, 2025

Copy link
Copy Markdown

Thanks @sobolevn for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 22, 2025
@sobolevn @AA-Turner @miss-islington
pythongh-121970: Replace .. coroutine{method,function} with `:async…
7870255 
…:` (pythonGH-130448)

(cherry picked from commit 5ec4bf8)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@miss-islington-app

miss-islington-app Bot commented Feb 22, 2025

Copy link
Copy Markdown

Sorry, @sobolevn and @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 5ec4bf86b7f4455432aebace996ef390ae3e9302 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned AA-Turner Feb 22, 2025
@bedevere-app

bedevere-app Bot commented Feb 22, 2025

Copy link
Copy Markdown

GH-130465 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 22, 2025
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Feb 22, 2025
@sobolevn @AA-Turner
[3.12] pythongh-121970: Replace .. coroutine{method,function} with …
36ecbfb 
…`:async:` (pythonGH-130448)

(cherry picked from commit 5ec4bf8)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 22, 2025

Copy link
Copy Markdown

GH-130467 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 22, 2025
AA-Turner added a commit that referenced this pull request Feb 22, 2025
@miss-islington @sobolevn @AA-Turner
[3.13] gh-121970: Replace .. coroutine{method,function} with `:asyn…
c68a872 
…c:` (GH-130448) (#130465)

(cherry picked from commit 5ec4bf8)

Co-authored-by: sobolevn <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
AA-Turner added a commit that referenced this pull request Feb 22, 2025
@AA-Turner @sobolevn
[3.12] gh-121970: Replace .. coroutine{method,function} with `:asyn…
9bd92fa 
…c:` (GH-130448) (#130467)

(cherry picked from commit 5ec4bf8)

Co-authored-by: sobolevn <[email protected]>
asvetlov
asvetlov approved these changes Feb 23, 2025
View reviewed changes
Mr-Sunglasses pushed a commit to Mr-Sunglasses/cpython that referenced this pull request Feb 24, 2025
@sobolevn @Mr-Sunglasses
pythongh-121970: Replace .. coroutine{method,function} with `:async…
48cb5b5 
…:` (python#130448)

Co-authored-by: Adam Turner <[email protected]>

pythongh-130461: Fix locations of `.. index::` directives usage in `Doc/library/uuid.rst`

pythongh-130461: Fix locations of `.. index::` in `getnode()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments
@asvetlov asvetlov asvetlov approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes
@willingc willingc Awaiting requested review from willingc willingc is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@AA-Turner AA-Turner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sobolevn @AA-Turner @asvetlov @kumaraditya303 @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.