GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130461: Remove unnecessary usages of `.. index::` directives in Doc/library/uuid.rst by Mr-Sunglasses · Pull Request #130526 · python/cpython

Conversation

@Mr-Sunglasses

@Mr-Sunglasses Mr-Sunglasses commented Feb 24, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

fix: #130461

  • Issue: Remove unnecessary usages of .. index:: directives in Doc/library/uuid.rst #130461

📚 Documentation preview 📚: https://cpython-previews--130526.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Mr-Sunglasses added 2 commits February 25, 2025 04:13
@Mr-Sunglasses
pythongh-130461: Remove unnecessary usages of .. index:: directives…
e6fd0d9 
… in Doc/library/uuid.rst
@Mr-Sunglasses
chore: add NEWS entry for the change
113be97
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir awaiting review labels Feb 24, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 24, 2025
Remove unnecessary usages of .. index:: directives in Doc/library/uuid.rst #130461
Closed
@Mr-Sunglasses

Mr-Sunglasses commented Feb 24, 2025

Copy link
Copy Markdown
Contributor Author

@picnixz , I've done the changes, Please Review it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Feb 24, 2025
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2025-02-25-03-53-00.gh-issue-130461.asr2dg.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Mr-Sunglasses @picnixz
chore: Update Misc/NEWS.d/next/Library/2025-02-25-03-53-00.gh-issue-1…
a4e30c5 
…30461.asr2dg.rst

Co-authored-by: Bénédikt Tran <[email protected]>
@picnixz
picnixz requested review from AA-Turner and hugovk February 24, 2025 23:03
@picnixz picnixz mentioned this pull request Feb 24, 2025
gh-130461: Fix locations of .. index:: directives usage in uuid docs #130468
Closed
picnixz
picnixz approved these changes Feb 24, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Feb 24, 2025
hugovk
hugovk approved these changes Feb 25, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Mr-Sunglasses reacted with heart emoji
All reactions
  • ❤️ 1 reaction
picnixz added a commit to picnixz/cpython that referenced this pull request Feb 25, 2025
@picnixz
remove .. index:: directive in prevision of pythongh-130526
70872bf
@hugovk
hugovk merged commit 85f1cc8 into python:main Feb 25, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 25, 2025
@hugovk hugovk added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Feb 25, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 25, 2025

Copy link
Copy Markdown

Thanks @Mr-Sunglasses for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Feb 25, 2025

Copy link
Copy Markdown

Thanks @Mr-Sunglasses for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app

miss-islington-app Bot commented Feb 25, 2025

Copy link
Copy Markdown

Sorry, @Mr-Sunglasses and @hugovk, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 85f1cc8d60b06d5b2af3e4da8e4f98171420dd91 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned hugovk Feb 25, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 25, 2025

Copy link
Copy Markdown

Sorry, @Mr-Sunglasses and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 85f1cc8d60b06d5b2af3e4da8e4f98171420dd91 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Feb 25, 2025

Copy link
Copy Markdown
Member

The conflicts are because uuid8 doesn't exist in 3.12/3.13 I think
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Feb 25, 2025

Copy link
Copy Markdown
Member

@Mr-Sunglasses Please could you do the backports?
Mr-Sunglasses reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Mr-Sunglasses

Mr-Sunglasses commented Feb 25, 2025

Copy link
Copy Markdown
Contributor Author

@Mr-Sunglasses Please could you do the backports?

Sure I'll do it :-)
hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk mentioned this pull request Feb 25, 2025
gh-89083: add support for UUID version 6 (RFC 9562) #120650
Merged
@Mr-Sunglasses Mr-Sunglasses mentioned this pull request Feb 25, 2025
[3.12] gh-130461: Remove unnecessary usages of .. index:: directives in Doc/library/uuid.rst (#130526) #130546
Merged
@bedevere-app

bedevere-app Bot commented Feb 25, 2025

Copy link
Copy Markdown

GH-130546 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 25, 2025
@Mr-Sunglasses Mr-Sunglasses mentioned this pull request Feb 25, 2025
[3.13] gh-130461: Remove unnecessary usages of .. index:: directives in Doc/library/uuid.rst (#130526) #130548
Merged
Mr-Sunglasses added a commit to Mr-Sunglasses/cpython that referenced this pull request Feb 25, 2025
@Mr-Sunglasses @picnixz
pythongh-130461: Remove unnecessary usages of .. index:: directives…
dc6d1e3 
… in Doc/library/uuid.rst (python#130526)

Co-authored-by: Bénédikt Tran <[email protected]>
(cherry picked from commit 85f1cc8)
@bedevere-app

bedevere-app Bot commented Feb 25, 2025

Copy link
Copy Markdown

GH-130548 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 25, 2025
@bedevere-app

bedevere-app Bot commented Feb 25, 2025

Copy link
Copy Markdown

GH-130546 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Feb 25, 2025

Copy link
Copy Markdown

GH-130548 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk pushed a commit that referenced this pull request Feb 25, 2025
@Mr-Sunglasses @picnixz
[3.13] gh-130461: Remove unnecessary usages of .. index:: directive…
28bfc1c 
…s in Doc/library/uuid.rst (#130526) (#130548)

Co-authored-by: Bénédikt Tran <[email protected]>
hugovk added a commit that referenced this pull request Feb 25, 2025
@Mr-Sunglasses @picnixz @hugovk
[3.12] gh-130461: Remove unnecessary usages of .. index:: directive…
ca9e52d 
…s in Doc/library/uuid.rst (#130526) (#130546)

Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@picnixz picnixz picnixz approved these changes
@AA-Turner AA-Turner Awaiting requested review from AA-Turner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@hugovk hugovk

Labels

docs Documentation in the Doc dir

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove unnecessary usages of .. index:: directives in Doc/library/uuid.rst

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Mr-Sunglasses @picnixz @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.