GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128982: Revert "#128982: Substitute regular expression in http.cookiejar.join_header_words for an efficient alternative (GH-128983)" and add tests by encukou · Pull Request #130584 · python/cpython

Conversation

@encukou

@encukou encukou commented Feb 26, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Revert "#128982: Substitute regular expression in http.cookiejar.join_header_words for an efficient alternative (GH-128983)"

This reverts commit 56e1900.

Add additional tests.

  • Issue: Improve performance of http.cookiejar.join_header_words #128982

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
encukou added 2 commits February 26, 2025 14:55
@encukou
Revert "pythongh-128982: Substitute regular expression in `http.cooki…
9d37429 
…ejar.join_header_words` for an efficient alternative (pythonGH-128983)"

This reverts commit 56e1900.
@encukou
Add tests
f09bd70
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 26, 2025
Improve performance of http.cookiejar.join_header_words #128982
Closed
@hugovk

hugovk commented Feb 26, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

These tests also pass on main (with #128983 / 56e1900), can we add one that fails before this revert?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Feb 26, 2025

Copy link
Copy Markdown
Member

Sorry! I had a branch mixup, these are indeed failing on main 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou

encukou commented Feb 26, 2025

Copy link
Copy Markdown
Member Author

I'm glad I'm not the only confused reviewer today ^^;
hugovk reacted with laugh emoji
All reactions
  • 😄 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit 9e474a9 into python:main Feb 26, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 26, 2025
@encukou
encukou deleted the revert-56e1900 branch February 26, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.