GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128982: Substitute regular expression in `http.cookiejar.join_header_words` for an efficient alternative by picnixz · Pull Request #128983 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jan 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Benchmarks are on the issue.

  • Issue: Improve performance of http.cookiejar.join_header_words #128982

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 2 commits January 18, 2025 11:36
@picnixz
Improve the performance http.cookiejar.join_header_words.
72b6c36 
The function does not anymore rely on a regular expression
to find alphanumeric characters and underscores.
@picnixz
blurb
0bbced2
@bedevere-app bedevere-app Bot added the awaiting core review label Jan 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jan 18, 2025
Improve performance of http.cookiejar.join_header_words #128982
Closed
@picnixz
Merge branch 'main' into perf/match/cookiejar-128982
dd230f4
tomasr8
tomasr8 approved these changes Jan 19, 2025
View reviewed changes
@picnixz
Merge remote-tracking branch 'upstream/main' into perf/match/cookieja…
f5b23bd 
…r-128982
@picnixz
picnixz requested a review from vadmium February 12, 2025 11:21
@picnixz picnixz mentioned this pull request Feb 16, 2025
Improve speed of stdlib functions by replacing re uses #130167
Open
@picnixz
picnixz requested a review from serhiy-storchaka February 23, 2025 11:03
@encukou
encukou merged commit 56e1900 into python:main Feb 26, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Feb 26, 2025
serhiy-storchaka
serhiy-storchaka reviewed Feb 26, 2025
View reviewed changes
Comment thread Lib/http/cookiejar.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
encukou added a commit to encukou/cpython that referenced this pull request Feb 26, 2025
@encukou
Revert "pythongh-128982: Substitute regular expression in `http.cooki…
9d37429 
…ejar.join_header_words` for an efficient alternative (pythonGH-128983)"

This reverts commit 56e1900.
@encukou encukou mentioned this pull request Feb 26, 2025
gh-128982: Revert "#128982: Substitute regular expression in http.cookiejar.join_header_words for an efficient alternative (GH-128983)" and add tests #130584
Merged
encukou added a commit that referenced this pull request Feb 26, 2025
@encukou
gh-128982: Revert "#128982: Substitute regular expression in http.coo…
9e474a9 
…kiejar.join_header_words for an efficient alternative (GH-128983)" and add tests (GH-130584)

* Revert "gh-128982: Substitute regular expression in `http.cookiejar.join_header_words` for an efficient alternative (GH-128983)"

This reverts commit 56e1900.

* Add tests
@picnixz
picnixz deleted the perf/match/cookiejar-128982 branch March 1, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@tomasr8 tomasr8 tomasr8 approved these changes
@vadmium vadmium Awaiting requested review from vadmium

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@picnixz @serhiy-storchaka @tomasr8 @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.