GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124878: Add temporary TSAN suppression for free_threadstate by colesbury · Pull Request #130602 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Feb 26, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The race condition with free_threadstate and daemon threads exists in both the free threading and default builds. We were missing a suppression in the default build.

  • Issue: race condition in threading when interpreter finalized while daemon thread runs (thread sanitizer identified) #124878

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
pythongh-124878: Add temporary suppression for free_threadstate
c5f5328 
The race condition with `free_threadstate` and daemon threads exists in
both the free threading and default builds. We were missing a
suppression in the default build.
@colesbury colesbury added skip news needs backport to 3.13 only security fixes labels Feb 26, 2025
@colesbury
colesbury requested a review from mpage February 26, 2025 20:41
@bedevere-app bedevere-app Bot mentioned this pull request Feb 26, 2025
race condition in threading when interpreter finalized while daemon thread runs (thread sanitizer identified) #124878
Closed
@colesbury colesbury changed the title gh-124878: Add temporary suppression for free_threadstate gh-124878: Add temporary TSAN suppression for free_threadstate Feb 26, 2025
@colesbury
colesbury marked this pull request as ready for review February 26, 2025 21:08
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 26, 2025
mpage
mpage approved these changes Feb 28, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 28, 2025
@colesbury
colesbury merged commit cc17307 into python:main Feb 28, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 28, 2025

Copy link
Copy Markdown

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 28, 2025
@colesbury
colesbury deleted the gh-124878-tsan-skip branch February 28, 2025 14:27
@miss-islington-app

miss-islington-app Bot commented Feb 28, 2025

Copy link
Copy Markdown

Sorry, @colesbury, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cc17307faaa248535c65f6a7668e06dc8ef04575 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned colesbury Feb 28, 2025
colesbury added a commit to colesbury/cpython that referenced this pull request Feb 28, 2025
@colesbury
[3.13] pythongh-124878: Add temporary TSAN suppression for free_threa…
a99aac3 
…dstate (pythongh-130602)

The race condition with `free_threadstate` and daemon threads exists in
both the free threading and default builds. We were missing a
suppression in the default build.
(cherry picked from commit cc17307)

Co-authored-by: Sam Gross <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 28, 2025

Copy link
Copy Markdown

GH-130687 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 28, 2025
colesbury added a commit that referenced this pull request Feb 28, 2025
@colesbury
[3.13] gh-124878: Add temporary TSAN suppression for free_threadstate (…
137595f 
…gh-130602) (gh-130687)

The race condition with `free_threadstate` and daemon threads exists in
both the free threading and default builds. We were missing a
suppression in the default build.
(cherry picked from commit cc17307)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpage mpage mpage approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@colesbury colesbury

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@colesbury @mpage
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.