GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-121970: Extract ``issue_role`` into a new extension by AA-Turner · Pull Request #130615 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Feb 26, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Improve and reorganise pyspecific #121970

📚 Documentation preview 📚: https://cpython-previews--130615.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AA-Turner added 2 commits February 26, 2025 22:49
@AA-Turner
Extract issue_role into a new extension
dd80b62
@AA-Turner
Convert to SphinxRole
28087ba
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Feb 26, 2025
@AA-Turner
AA-Turner requested a review from hugovk as a code owner February 26, 2025 22:51
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 26, 2025
@AA-Turner AA-Turner changed the title GH-121970: Extract issue_role into a new extension GH-121970: Extract issue_role into a new extension Feb 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 26, 2025
Improve and reorganise pyspecific #121970
Open
@AA-Turner
Remove {GH_}ISSUE_URI from pyspecific
0282cf3
hugovk
hugovk reviewed Feb 27, 2025
View reviewed changes
Comment thread Doc/tools/extensions/issue_role.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/tools/extensions/issue_role.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/tools/extensions/issue_role.py
return [prb], [msg]

issue_url = self.ISSUE_URI.format(issue)
refnode = nodes.reference(issue, f"bpo-{issue}", refuri=issue_url)

@hugovk hugovk Feb 27, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we're passing something like 12345 and bpo-12345 as the first two arguments.

Before we were passing something like bpo-12345 and bpo-12345 for both.

I see the second one is used in the refnode:

<reference refuri="https://bugs.python.org/issue?@action=redirect&bpo=13936">bpo-13936</reference>

How is the first one used?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AA-Turner AA-Turner Feb 27, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the docutils rawsource, it should reflect what was actually written in the document.

Sphinx uses this for translation, I don't think these nodes are translatable but I'll double check.

A

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AA-Turner AA-Turner Feb 27, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See e.g. https://github.com/python/python-docs-fr/blob/3.13/whatsnew/3.13.po#L394-L399, the whole role is included in the translation string.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@hugovk hugovk Feb 27, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should it match 12345 or bpo-12345?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@hugovk hugovk Feb 27, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Unresolving so the question isn't hidden :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AA-Turner AA-Turner Feb 27, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text of what is actually written in the document, so "14159".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/tools/extensions/issue_role.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner and others added 2 commits February 27, 2025 14:21
@AA-Turner @hugovk
Hugo's review
6fa8680 
Co-authored-by: Hugo van Kemenade <[email protected]>
@AA-Turner
Revert TC=False
3b46c04
hugovk
hugovk approved these changes Feb 27, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Feb 27, 2025
@AA-Turner
AA-Turner merged commit 043ab3a into python:main Feb 27, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Feb 27, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Feb 27, 2025
@miss-islington-app

miss-islington-app Bot commented Feb 27, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner deleted the docs/issue-role branch February 27, 2025 19:06
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2025
@AA-Turner @hugovk @miss-islington
pythonGH-121970: Extract issue_role into a new extension (pythonG…
9bc2331 
…H-130615)

(cherry picked from commit 043ab3a)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 27, 2025

Copy link
Copy Markdown

GH-130651 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Feb 27, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 27, 2025
@AA-Turner @hugovk @miss-islington
pythonGH-121970: Extract issue_role into a new extension (pythonG…
de65166 
…H-130615)

(cherry picked from commit 043ab3a)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
@bedevere-app

bedevere-app Bot commented Feb 27, 2025

Copy link
Copy Markdown

GH-130652 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 27, 2025
AA-Turner added a commit that referenced this pull request Feb 27, 2025
@miss-islington @AA-Turner @hugovk
[3.13] GH-121970: Extract issue_role into a new extension (GH-130615
b53065a 
) (#130651)

(cherry picked from commit 043ab3a)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
AA-Turner added a commit that referenced this pull request Feb 27, 2025
@miss-islington @AA-Turner @hugovk
[3.12] GH-121970: Extract issue_role into a new extension (GH-130615
245ca26 
) (#130652)

(cherry picked from commit 043ab3a)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@AA-Turner @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.