GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130631: Make join_header_words() more similar to the original Perl version by serhiy-storchaka · Pull Request #130632 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Feb 27, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Always quote strings with non-ASCII characters.
  • Allow some non-separator and non-control characters (like "." or "-") be unquoted.
  • Always quote string that end with "\n".
  • Use the fullmatch() method for clarity and optimization.
  • Issue: Make join_header_words() more similar to the original #130631

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-130631: Make join_header_words() more similar to the origina…
c075088 
…l Perl version

* Always quote strings with non-ASCII characters.
* Allow some non-separator and non-control characters (like "." or "-")
  be unquoted.
* Always quote string that end with "\n".
* Use the fullmatch() method for clarity and optimization.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Feb 27, 2025
@serhiy-storchaka
serhiy-storchaka requested a review from encukou February 27, 2025 12:26
@bedevere-app bedevere-app Bot added the awaiting core review label Feb 27, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Feb 27, 2025
Make join_header_words() more similar to the original #130631
Closed
serhiy-storchaka added 3 commits April 2, 2025 20:38
@serhiy-storchaka
Merge branch 'main' into join_header_words
eedd1ff
@serhiy-storchaka
Fix tests.
9e8cecf
@serhiy-storchaka
Silence Sphynx warning.
2a3a102
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.12 only security fixes label Apr 9, 2025
@serhiy-storchaka
serhiy-storchaka merged commit 7ebbd27 into python:main Apr 9, 2025
@miss-islington-app

miss-islington-app Bot commented Apr 9, 2025

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 9, 2025
@serhiy-storchaka
serhiy-storchaka deleted the join_header_words branch April 9, 2025 08:08
@miss-islington-app

miss-islington-app Bot commented Apr 9, 2025

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 7ebbd271444d89218870169624921b795a717470 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka Apr 9, 2025
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 9, 2025
@serhiy-storchaka
[3.13] pythongh-130631: Make join_header_words() more similar to the …
d6c5ce3 
…original Perl version (pythonGH-130632)

* Always quote strings with non-ASCII characters.
* Allow some non-separator and non-control characters (like "." or "-")
  be unquoted.
* Always quote strings that end with "\n".
* Use the fullmatch() method for clarity and optimization.
(cherry picked from commit 7ebbd27)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 9, 2025

Copy link
Copy Markdown

GH-132303 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 9, 2025
serhiy-storchaka added a commit that referenced this pull request Apr 9, 2025
@serhiy-storchaka
[3.13] gh-130631: Make join_header_words() more similar to the origin…
8e97bd7 
…al Perl version (GH-130632) (GH-132303)

* Always quote strings with non-ASCII characters.
* Allow some non-separator and non-control characters (like "." or "-")
  be unquoted.
* Always quote strings that end with "\n".
* Use the fullmatch() method for clarity and optimization.
(cherry picked from commit 7ebbd27)
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.