GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "GH-116380: Speed up `glob.[i]glob()` by making fewer system calls. (#116392)" by barneygale · Pull Request #130743 · python/cpython

Conversation

@barneygale

@barneygale barneygale commented Mar 1, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This broke tests on the 'aarch64 Fedora Stable Clang Installed 3.x' and 'AMD64 Fedora Stable Clang Installed 3.x' build bots.

This reverts commit da4899b.

  • Issue: Speed up glob.glob() by reducing number of system calls made #116380

📚 Documentation preview 📚: https://cpython-previews--130743.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@barneygale
Revert "pythonGH-116380: Speed up glob.[i]glob() by making fewer sy…
43a9885 
…stem calls. (python#116392)"

This broke tests on the 'aarch64 Fedora Stable Clang Installed 3.x' and
'AMD64 Fedora Stable Clang Installed 3.x' build bots.

This reverts commit da4899b.
@barneygale barneygale added the skip news label Mar 1, 2025
@barneygale
barneygale requested a review from picnixz March 1, 2025 19:36
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 1, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 1, 2025
Speed up glob.glob() by reducing number of system calls made #116380
Open
@barneygale barneygale changed the title Revert "GH-116380: Speed up glob.[i]glob() by making fewer system calls. (#116392) Revert "GH-116380: Speed up glob.[i]glob() by making fewer system calls. (#116392)" Mar 1, 2025
picnixz
picnixz approved these changes Mar 1, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this a simple application of git revert the I think I can approve it without looking at it too long right?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
barneygale reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 1, 2025
@barneygale

barneygale commented Mar 1, 2025

Copy link
Copy Markdown
Contributor Author

Indeed, it's a git revert with no embellishments :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
barneygale enabled auto-merge (squash) March 1, 2025 19:43
@picnixz

picnixz commented Mar 1, 2025

Copy link
Copy Markdown
Member

In this case (and in the future), I think you don't need my approval then :) (it would be too hard to actually check that the revert is correct using the web UI)
barneygale reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@barneygale
barneygale merged commit 5326c27 into python:main Mar 1, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 1, 2025
@picnixz picnixz mentioned this pull request Mar 2, 2025
GH-116380: Revert addition of test_iglob_iter_close test #130710
Closed
@barneygale barneygale mentioned this pull request Aug 6, 2025
GH-116380: Speed up glob.[i]glob() by making fewer system calls (take 2) #137474
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@barneygale @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.