GeezerVison

Needs a fix for #116377 to land.

Thanks Serhiy! We use os.scandir() if either:

1. We're expanding a recursive wildcard (we need to distinguish directories in order to recurse)
2. We're expanding a non-final non-recursive wildcard (we need to select only directories)

If neither of these are true, then we don't need to stat() the children, and so os.listdir() is actually a little faster I think. But I will test this on a few machines to be sure!

edit: to further illustrate what I mean, here's where os.listdir() is used:

The new implementation should be benchmarked with different test cases: deep and wide threes, files and directories domination.

I've been looking into this! The randomfiletree project is helpful - it can repeatedly walk a tree and create child files/folders according to a gaussian distribution, which seems to me like a good approximation for an average "shallow and wide" filesystem structure, including tweaking for file or folder distribution.

It's difficult to produce "deep and narrow" trees this way, as the file/folder probability would need to change with the depth (I think?). I've been considering writing a tree generator that works this way, e.g.:

• At depth==0, generate 100 subdirectories
• At 0 < depth < 50, generate 1 subdirectory
• At depth==50, generate 100 files

... but is that overly arbitrary? Is there a better way? Or do I just need to come up with a bunch of test cases along those lines?

A test of 100 nested directories named "deep" from my Linux machine:

@serhiy-storchaka FYI, this PR changes some of the test expectations you recently added in 8b5c850. Specifically, redundant slashes in the pattern are always preserved, and pattern separators are always normalized. Hopefully that's a reasonable price to pay for the speedups, the support for deep hierarchies, and the elimination of duplicate results

I'll merge this in about a week if there's no further feedback. Thanks all.

Great!

@barneygale Thanks for all the work you put into this PR.

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 Fedora Stable Clang Installed 3.x has failed when building commit da4899b.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/14/builds/7291) and take a look at the build logs.
4. Check if the failure is related to this commit (da4899b) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/14/builds/7291

Failed tests:

• test_glob

Failed subtests:

• test_iglob_iter_close - test.test_glob.GlobTests.test_iglob_iter_close

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-aarch64.clang-installed/build/target/lib/python3.14/test/test_glob.py", line 424, in test_iglob_iter_close
    self.assertEqual(next(iter), 'deep/d')
                     ~~~~^^^^^^
StopIteration

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Clang Installed 3.x has failed when building commit da4899b.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/350/builds/7433) and take a look at the build logs.
4. Check if the failure is related to this commit (da4899b) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/350/builds/7433

Failed tests:

• test_glob

Failed subtests:

• test_iglob_iter_close - test.test_glob.GlobTests.test_iglob_iter_close

Summary of the results of the build (if available):

==

Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-fedora-stable-x86_64.clang-installed/build/target/lib/python3.14/test/test_glob.py", line 424, in test_iglob_iter_close
    self.assertEqual(next(iter), 'deep/d')
                     ~~~~^^^^^^
StopIteration