GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-118518: Minor improvements to perf docs by stratakis · Pull Request #130866 · python/cpython

Conversation

@stratakis

@stratakis stratakis commented Mar 5, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Allow perf to work without frame pointers #118518

📚 Documentation preview 📚: https://cpython-previews--130866.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@stratakis
Minor improvements to perf docs
42e9678
@bedevere-app bedevere-app Bot added docs Documentation in the Doc dir skip news awaiting review labels Mar 5, 2025
@github-project-automation github-project-automation Bot added this to Docs PRs Mar 5, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Mar 5, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 5, 2025
Allow perf to work without frame pointers #118518
Closed
@stratakis

stratakis commented Mar 5, 2025

Copy link
Copy Markdown
Contributor Author

cc @pablogsal
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jstasiak
jstasiak reviewed Mar 8, 2025
View reviewed changes

@jstasiak jstasiak left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these changes actually related to the linked ticket?

FWIW I'd probably not attach this PR to a ticket that's been closed for that long.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@stratakis

stratakis commented Mar 9, 2025

Copy link
Copy Markdown
Contributor Author

The -k flag for perf is required for jited code so it's related to the linked ticket where the support was initially implemented. The rename of the script harmonizes the commands with the rest of the examples there.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Mar 10, 2025
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the PR @stratakis

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 10, 2025
@pablogsal pablogsal added the needs backport to 3.13 only security fixes label Mar 10, 2025
@pablogsal
pablogsal enabled auto-merge (squash) March 10, 2025 21:51
@pablogsal
pablogsal merged commit ecdf6b1 into python:main Mar 10, 2025
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Mar 10, 2025
@miss-islington-app

miss-islington-app Bot commented Mar 10, 2025

Copy link
Copy Markdown

Thanks @stratakis for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 10, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 10, 2025
@stratakis @miss-islington
pythongh-118518: Minor improvements to perf docs (pythonGH-130866)
c7a085c 
Minor improvements to perf docs
(cherry picked from commit ecdf6b1)

Co-authored-by: stratakis <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 10, 2025

Copy link
Copy Markdown

GH-131059 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 10, 2025
pablogsal pushed a commit that referenced this pull request Mar 28, 2025
@miss-islington @stratakis
[3.13] gh-118518: Minor improvements to perf docs (GH-130866) (#131059)
7f7fc54 
gh-118518: Minor improvements to perf docs (GH-130866)

Minor improvements to perf docs
(cherry picked from commit ecdf6b1)

Co-authored-by: stratakis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
+1 more reviewer
@jstasiak jstasiak jstasiak left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@stratakis @jstasiak @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.