GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-130664: treat '0' fill character with align '=' as zero-padding for Fraction's by skirpichev · Pull Request #131067 · python/cpython

Conversation

skirpichev commented Mar 11, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Undocumented handling of thousands separator for floats and differences wrt Decimal #130664

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-130664: treat '0' fill character with align '=' as zero-padd…

d46ca41

…ing for Fraction's

bedevere-app Bot added the awaiting review label

Mar 11, 2025

bedevere-app Bot mentioned this pull request

Mar 11, 2025

Undocumented handling of thousands separator for floats and differences wrt Decimal #130664

Open

skirpichev added 2 commits

April 6, 2025 14:04


          Merge branch 'master' into fraction-zeropad/130664

dd31833


          + cleanup

4aa9dc5

skirpichev added needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes and removed needs backport to 3.12 only security fixes labels

Apr 6, 2025

serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label

May 8, 2025

skirpichev requested a review from serhiy-storchaka

July 3, 2025 08:00

serhiy-storchaka approved these changes

Jul 3, 2025

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Jul 3, 2025

vstinner approved these changes

Jul 3, 2025

View reviewed changes

serhiy-storchaka merged commit c113a8e into python:main

Jul 3, 2025

miss-islington-app Bot commented Jul 3, 2025

Copy link

Copy Markdown

Thanks @skirpichev for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Jul 3, 2025

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 3, 2025


          pythongh-130664: Treat '0' fill character with align '=' as zero-padd…

7f65738

…ing for Fraction's (pythonGH-131067)

(cherry picked from commit c113a8e)

Co-authored-by: Sergey B Kirpichev <[email protected]>

bedevere-app Bot commented Jul 3, 2025

Copy link

Copy Markdown

GH-136241 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 3, 2025


          pythongh-130664: Treat '0' fill character with align '=' as zero-padd…

3a9fd7f

…ing for Fraction's (pythonGH-131067)

(cherry picked from commit c113a8e)

Co-authored-by: Sergey B Kirpichev <[email protected]>

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Jul 3, 2025

bedevere-app Bot commented Jul 3, 2025

Copy link

Copy Markdown

GH-136242 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Jul 3, 2025

skirpichev deleted the fraction-zeropad/130664 branch

July 3, 2025 11:02

serhiy-storchaka pushed a commit that referenced this pull request

Jul 3, 2025


          [3.13] gh-130664: Treat '0' fill character with align '=' as zero-pad…

c30178a

…ding for Fraction's (GH-131067) (GH-136242)

(cherry picked from commit c113a8e)

Co-authored-by: Sergey B Kirpichev <[email protected]>

serhiy-storchaka pushed a commit that referenced this pull request

Jul 3, 2025


          [3.14] gh-130664: Treat '0' fill character with align '=' as zero-pad…

4877f43

…ding for Fraction's (GH-131067) (GH-136241)

(cherry picked from commit c113a8e)

Co-authored-by: Sergey B Kirpichev <[email protected]>

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request

Jul 11, 2025


          pythongh-130664: Treat '0' fill character with align '=' as zero-padd…

26b57a7

…ing for Fraction's (pythonGH-131067)

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request

Jul 12, 2025


          pythongh-130664: Treat '0' fill character with align '=' as zero-padd…

6dbc3ff

…ing for Fraction's (pythonGH-131067)

picnixz pushed a commit to picnixz/cpython that referenced this pull request

Jul 13, 2025


          pythongh-130664: Treat '0' fill character with align '=' as zero-padd…

aec587f

…ing for Fraction's (pythonGH-131067)

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request

Aug 4, 2025


          pythongh-130664: Treat '0' fill character with align '=' as zero-padd…

b4aac30

…ing for Fraction's (pythonGH-131067)

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request

Aug 19, 2025


          pythongh-130664: Treat '0' fill character with align '=' as zero-padd…

d2d1eba

…ing for Fraction's (pythonGH-131067)

scoder added a commit to scoder/quicktions that referenced this pull request

Sep 8, 2025


          Thousands separator in formatting was handled differently than for fl…

c30e36b

…oats etc.

See python/cpython#131067

Reviewers

vstinner

vstinner approved these changes

serhiy-storchaka

serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

skirpichev commented Mar 11, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Jul 3, 2025

Uh oh!

bedevere-app Bot commented Jul 3, 2025

Uh oh!

bedevere-app Bot commented Jul 3, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

skirpichev commented Mar 11, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.