GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131152: Remove unused imports from tests (part 2) by vstinner · Pull Request #131154 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 12, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Remove unused imports - March 2025 Edition #131152

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-131152: Remove unused imports from tests (part 2)
0c5e97d
@vstinner vstinner added the skip news label Mar 12, 2025
@vstinner
vstinner requested review from FFY00, ambv, barneygale, brettcannon, ericsnowcurrently, ethanfurman, jaraco, lysnikolaou, ncoghlan, pablogsal, rhettinger and warsaw as code owners March 12, 2025 14:56
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 12, 2025
Remove unused imports - March 2025 Edition #131152
Closed
@picnixz picnixz mentioned this pull request Mar 12, 2025
gh-131152: Remove unused imports in tests #131169
Closed
pablogsal
pablogsal approved these changes Mar 12, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 12, 2025
rhettinger
rhettinger approved these changes Mar 12, 2025
View reviewed changes
@vstinner
vstinner merged commit b2ca268 into python:main Mar 13, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 13, 2025
@vstinner

vstinner commented Mar 13, 2025

Copy link
Copy Markdown
Member Author

Merged, thanks for reviews.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the unused_import4 branch March 13, 2025 09:57
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
@vstinner @plashchynski
pythongh-131152: Remove unused imports from tests (part 2) (python#13…
0cc71bc 
…1154)
jaraco
jaraco reviewed May 12, 2025
View reviewed changes
Comment thread Lib/test/test_zipfile/_path/test_path.py
import pickle
import stat
import sys
import time

@jaraco jaraco May 12, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will get overwritten unless it's ported to zipp. I'm slightly surprised that there are unused imports, given that I run ruff over the codebase. Oh, I see now. gh-123424 has not yet been backported to zipp, and that's where time was used. So shouldn't be a problem getting this synced once that one is.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jaraco jaraco jaraco left review comments
@rhettinger rhettinger rhettinger approved these changes
@pablogsal pablogsal pablogsal approved these changes
@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner
@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@ambv ambv Awaiting requested review from ambv ambv is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @jaraco @rhettinger @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.