GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: Change Argument Clinic signature for `@classmethod` by vstinner · Pull Request #131157 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 12, 2025 •
edited by picnixz
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Use "PyObject*", instead of "PyTypeObject*", for @classmethod functions to fix an undefined behavior.

  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-111178: Change Argument Clinic signature for @classmethod
4e142b8 
Use "PyObject*", instead of "PyTypeObject*", for @classmethod
functions to fix an undefined behavior.
@vstinner vstinner added the skip news label Mar 12, 2025
@vstinner
vstinner requested review from abalkin, erlend-aasland, gpshead, pganssle and rhettinger as code owners March 12, 2025 15:49
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 12, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
@picnixz

picnixz commented Mar 12, 2025

Copy link
Copy Markdown
Member

@vstinner I would advise rewriting the commit and use `@classmethod` so that github does not automatically mention them
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner changed the title gh-111178: Change Argument Clinic signature for @classmethod gh-111178: Change Argument Clinic signature for @classmethod Mar 12, 2025
@vstinner
Fix mypy
4edb4af
@vstinner
vstinner merged commit 061da44 into python:main Mar 12, 2025
@vstinner
vstinner deleted the clinic_self branch March 12, 2025 16:42
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 12, 2025
vstinner added a commit to vstinner/cpython that referenced this pull request Mar 12, 2025
@vstinner
pythongh-111178: Change Argument Clinic signature for @staticmethod (…
d5c7809 
…python#131157)

Use "PyObject*", instead of "void*", for `@staticmethod` functions to
fix an undefined behavior.
vstinner added a commit that referenced this pull request Mar 13, 2025
@vstinner
gh-111178: Change Argument Clinic signature for @staticmethod (#131157
2ed671b 
) (#131159)

Use "PyObject*", instead of "void*", for `@staticmethod` functions to
fix an undefined behavior.
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
@vstinner @plashchynski
pythongh-111178: Change Argument Clinic signature for @classmethod (p…
0927dc1 
…ython#131157)

Use "PyObject*", instead of "PyTypeObject*", for `@classmethod`
functions to fix an undefined behavior.
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
@vstinner @plashchynski
pythongh-111178: Change Argument Clinic signature for @staticmethod (…
2848124 
…python#131157) (python#131159)

Use "PyObject*", instead of "void*", for `@staticmethod` functions to
fix an undefined behavior.
@picnixz picnixz mentioned this pull request Mar 24, 2025
Make Argument Clinic aware of possible UBSan failures #128180
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
@gpshead gpshead Awaiting requested review from gpshead
@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner
@abalkin abalkin Awaiting requested review from abalkin

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.