GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-131296: fix clang-cl warnings on Windows in blake2module.c by chris-eibl · Pull Request #131299 · python/cpython

Conversation

@chris-eibl

@chris-eibl chris-eibl commented Mar 15, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fix

1>..\Modules\blake2module.c(77,9): warning : variable 'eax1' set but not used [-Wunused-but-set-variable]
1>..\Modules\blake2module.c(77,19): warning : variable 'ebx1' set but not used [-Wunused-but-set-variable]
1>..\Modules\blake2module.c(78,9): warning : variable 'eax7' set but not used [-Wunused-but-set-variable]
1>..\Modules\blake2module.c(78,29): warning : variable 'ecx7' set but not used [-Wunused-but-set-variable]
1>..\Modules\blake2module.c(78,39): warning : variable 'edx7' set but not used [-Wunused-but-set-variable]

we see them two (non-PGO) or three times, because the _freeze_module compiles blake2module.c, too.

I think this is a skip news.

  • Issue: clang-cl issues many warnings when building on Windows #131296

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@chris-eibl
fix clang-cl warnings in blake2module.c
8d54da9
@chris-eibl
chris-eibl requested review from gpshead, picnixz and tiran as code owners March 15, 2025 18:06
@bedevere-app bedevere-app Bot added the awaiting review label Mar 15, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 15, 2025
clang-cl issues many warnings when building on Windows #131296
Closed
@gpshead gpshead added the skip news label Mar 15, 2025
gpshead
gpshead approved these changes Mar 15, 2025
View reviewed changes
Comment thread Modules/blake2module.c
edx7 = info7[3];
#else
#endif
(void) eax1; (void) ebx1; (void) ecx1; (void) edx1;

@gpshead gpshead Mar 15, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL... definitely fighting against the compiler's idea of best practices here using useless no-op statements as a way to work around it. i wish we could disable a specific warning for a whole block of code. i feel like a future compiler will notice that these are useless and stop considering them a "use".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
chris-eibl reacted with laugh emoji
All reactions
  • 😄 1 reaction

@chris-eibl chris-eibl Mar 15, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was just the least minimal change to silence the warning :)

Luckily, I think we'll never have to fear that this will ever need a change: that (void) pattern is adapted by all known compilers for ages - and I think this will stay.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 15, 2025
@gpshead
gpshead merged commit faa80fc into python:main Mar 15, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 15, 2025
picnixz
picnixz approved these changes Mar 15, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we would have used (void) ... in the elif branch but it would be an overkill for foolish consistency.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
chris-eibl reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
Comment thread Modules/blake2module.c
(void) eax1; (void) ebx1; (void) ecx1; (void) edx1;
(void) eax7; (void) ebx7; (void) ecx7; (void) edx7;
#endif

@picnixz picnixz Mar 15, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the double blank lines L98/L99 please? TiA

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz

picnixz commented Mar 15, 2025

Copy link
Copy Markdown
Member

Oh it was merged :')
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chris-eibl
chris-eibl deleted the fix_clangcl_blake2module branch March 15, 2025 19:18
plashchynski pushed a commit to plashchynski/cpython that referenced this pull request Mar 17, 2025
@chris-eibl @plashchynski
pythonGH-131296: fix clang-cl warnings on Windows in blake2module.c (p…
1b7fc96 
…ython#131299)

work around unimportant clang-cl warnings in blake2module.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@picnixz picnixz picnixz approved these changes
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@chris-eibl @picnixz @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.