GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-124666: Improve thread cleanup in test_android by mhsmith · Pull Request #131427 · python/cpython

Conversation

@mhsmith

@mhsmith mhsmith commented Mar 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The hanging buildbot in #124666 was caused by a leftover thread created in the test's setUp method. It was supposed to be cleaned up by tearDown, but that isn't called automatically when setUp fails.

I still don't know why the underlying test failure was happening, but I've increased all the timeouts to LOOPBACK_TIMEOUT (10 seconds) in case that makes a difference.

Also cleaned up a couple of other test failure logging issues.

  • Fixes Intermittent buildbot failure and timeout on Android aarch64 #124666

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mhsmith
Improve thread cleanup in test_android
4997d1b
@mhsmith mhsmith added skip news needs backport to 3.13 only security fixes labels Mar 18, 2025
@mhsmith
mhsmith requested a review from freakboy3742 as a code owner March 18, 2025 19:45
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Mar 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 18, 2025
Intermittent buildbot failure and timeout on Android aarch64 #124666
Closed
@mhsmith

mhsmith commented Mar 18, 2025

Copy link
Copy Markdown
Member Author

!buildbot android
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Mar 18, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @mhsmith for commit 4997d1b 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131427%2Fmerge

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
freakboy3742
freakboy3742 approved these changes Mar 18, 2025
View reviewed changes

@freakboy3742 freakboy3742 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable set of fixes to me. If nothing else, I guess this means the failure case will actually fail, rather than timing out, which is a definite improvement; maybe the new failure will reveal more detail about why it's failing? (We can but hope :-) )

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 18, 2025
@freakboy3742
freakboy3742 merged commit 01b5abb into python:main Mar 18, 2025
@miss-islington-app

miss-islington-app Bot commented Mar 18, 2025

Copy link
Copy Markdown

Thanks @mhsmith for the PR, and @freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 18, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 18, 2025
@mhsmith @miss-islington
pythongh-124666: Improve thread cleanup in test_android (pythonGH-131427
7f13df4 
)

Ensures that failures in test setup don't result in dangling threads.
(cherry picked from commit 01b5abb)

Co-authored-by: Malcolm Smith <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 18, 2025

Copy link
Copy Markdown

GH-131433 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 18, 2025
freakboy3742 pushed a commit that referenced this pull request Mar 19, 2025
@miss-islington @mhsmith
[3.13] gh-124666: Improve thread cleanup in test_android (GH-131427) (#…
ff286a3 
…131433)

Ensures that failures in test setup don't result in dangling threads.
(cherry picked from commit 01b5abb)

Co-authored-by: Malcolm Smith <[email protected]>
colesbury pushed a commit to colesbury/cpython that referenced this pull request Mar 20, 2025
@mhsmith @colesbury
pythongh-124666: Improve thread cleanup in test_android (python#131427)
1a2d35e 
Ensures that failures in test setup don't result in dangling threads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Intermittent buildbot failure and timeout on Android aarch64

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mhsmith @bedevere-bot @freakboy3742
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.