GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Enable Windows on Arm GitHub runners by diegorusso · Pull Request #131559 · python/cpython

Conversation

diegorusso commented Mar 21, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

I had to put some if conditions in different steps because these runners are not generally available hence skipping checks on forks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

diegorusso requested review from AA-Turner, brandtbucher, ezio-melotti, hugovk and savannahostrowski as code owners

March 21, 2025 17:34

bedevere-app Bot added the awaiting review label

Mar 21, 2025

diegorusso added skip issue skip news infra CI, GitHub Actions, buildbots, Dependabot, etc. labels

Mar 21, 2025

diegorusso force-pushed the windows-aarch64-runners branch from 77d3e04 to c3f95a3 Compare

March 21, 2025 17:39

brandtbucher commented Mar 21, 2025

Copy link

Copy Markdown

Member

Exciting! I think the JIT failure should be fixed on main, as of late yesterday, so merging it in should help.

diegorusso reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

brandtbucher commented Mar 21, 2025

Copy link

Copy Markdown

Member

...looks like JIT builds were broken again.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner reviewed

Mar 22, 2025

View reviewed changes

Comment thread

.github/workflows/reusable-windows-msi.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

diegorusso marked this pull request as draft

March 22, 2025 16:34

bedevere-app Bot removed the awaiting review label

Mar 22, 2025

diegorusso marked this pull request as ready for review

March 27, 2025 16:24

bedevere-app Bot added the awaiting review label

Mar 27, 2025

AA-Turner changed the title ~~Enable Windows on Arm GitHub runners.~~ Enable Windows on Arm GitHub runners

Mar 27, 2025

hugovk reviewed

Mar 27, 2025

View reviewed changes

Comment thread

.github/workflows/build.yml Outdated

		- true
		include:
		- os: windows-latest # FIXME(diegorusso): change to os: windows-aarch64
		- os: windows-aarch64

hugovk Mar 27, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this runner only available for select projects right now?

Do you know when it might be more widely available, and can we add some default for forks in the meantime?

It looks like we're missing Windows entirely on forks:

upstream	fork

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

diegorusso Mar 27, 2025

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. At the moment these are available on selected projects for now. I'm not sure when they will be in GA. I will ask and report back.
I'll add something to skip the aarch64 on forks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

diegorusso Mar 28, 2025

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you double check if you have Windows runners available on forks without my patch? See here: https://github.com/diegorusso/cpython/actions/runs/14119011738

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

diegorusso Mar 28, 2025

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also CIFuzz are skipped.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hugovk Mar 28, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I do have Windows runners on forks without this patch, here's main and a branch from main:

Note #131702 was merged 3 days ago to fix a Windows skip when running on main, and I don't think we have that here yet? Let's first update this PR from main and re-check.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

diegorusso Mar 28, 2025

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah maybe I need to rebase the branch then.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hugovk Mar 28, 2025

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click the magic button:

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

diegorusso Mar 31, 2025

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

.github/workflows/jit.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.

diegorusso force-pushed the windows-aarch64-runners branch 2 times, most recently from 152c36b to 3388831 Compare

April 1, 2025 10:03

diegorusso requested review from AlexWaygood, JelleZijlstra, barneygale, brettcannon, corona10, ericsnowcurrently, erlend-aasland, ethanfurman and freakboy3742 as code owners

April 1, 2025 10:03

diegorusso requested review from 1st1, Fidget-Spinner, asvetlov, carljm, iritkatriel, kumaraditya303, methane, picnixz, tiran and willingc as code owners

April 1, 2025 10:03

diegorusso closed this

Apr 1, 2025

diegorusso force-pushed the windows-aarch64-runners branch from 3388831 to 3b3720f Compare

April 1, 2025 10:04

picnixz removed request for a team, 1st1, JelleZijlstra, asvetlov, barneygale, berkerpeksag, brettcannon, carljm, ericsnowcurrently, freakboy3742, gpshead, iritkatriel, methane, ncoghlan, pganssle, rhettinger, tiran and warsaw

April 1, 2025 10:06

Reviewers

hugovk

hugovk left review comments

AA-Turner

AA-Turner left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review infra

CI, GitHub Actions, buildbots, Dependabot, etc.

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

diegorusso commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brandtbucher commented Mar 21, 2025

Uh oh!

brandtbucher commented Mar 21, 2025

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

diegorusso commented Mar 21, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.