GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-128446: Run Windows CI tests on each commit by AA-Turner · Pull Request #131702 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Mar 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This was missed in #128450.

A

  • Issue: Skip Windows CI for configure/Makefile changes #128446

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
colesbury reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@AA-Turner
Run Windows CI tests on each commit
494220f
@AA-Turner AA-Turner added skip news needs backport to 3.12 only security fixes needs backport to 3.13 only security fixes labels Mar 25, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 25, 2025
Skip Windows CI for configure/Makefile changes #128446
Closed
zanieb
zanieb approved these changes Mar 25, 2025
View reviewed changes
hugovk
hugovk approved these changes Mar 25, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 25, 2025
@hugovk
hugovk merged commit 7d9442f into python:main Mar 25, 2025
@miss-islington-app

miss-islington-app Bot commented Mar 25, 2025

Copy link
Copy Markdown

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 25, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2025
@AA-Turner @miss-islington
pythongh-128446: Run Windows CI tests on each commit (pythonGH-131702)
c667f6a 
(cherry picked from commit 7d9442f)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 25, 2025

Copy link
Copy Markdown

GH-131705 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Mar 25, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 25, 2025
@AA-Turner @miss-islington
pythongh-128446: Run Windows CI tests on each commit (pythonGH-131702)
aae9d72 
(cherry picked from commit 7d9442f)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app

bedevere-app Bot commented Mar 25, 2025

Copy link
Copy Markdown

GH-131706 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Mar 25, 2025
@hugovk

hugovk commented Mar 25, 2025

Copy link
Copy Markdown
Member

The Windows build is running on main now:

image

https://github.com/python/cpython/actions/runs/14053641267/job/39348432127

Should it also run Windows MSI?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner deleted the win-test branch March 25, 2025 20:19
@AA-Turner

AA-Turner commented Mar 25, 2025

Copy link
Copy Markdown
Member Author

Should it also run Windows MSI?

Previously this wasn't run for each commit. I'm cautious about adding more jobs to CI, due to limited resources, and it might be that the MSI tests are run by the buildbots.

A
hugovk reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk mentioned this pull request Mar 28, 2025
Enable Windows on Arm GitHub runners #131559
Closed
hugovk pushed a commit that referenced this pull request Mar 28, 2025
@miss-islington @AA-Turner
[3.13] gh-128446: Run Windows CI tests on each commit (GH-131702) (#1…
2ccb84a 
…31705)

gh-128446: Run Windows CI tests on each commit (GH-131702)
(cherry picked from commit 7d9442f)

Co-authored-by: Adam Turner <[email protected]>
hugovk pushed a commit that referenced this pull request Mar 28, 2025
@miss-islington @AA-Turner
[3.12] gh-128446: Run Windows CI tests on each commit (GH-131702) (#1…
4f7b66a 
…31706)

gh-128446: Run Windows CI tests on each commit (GH-131702)
(cherry picked from commit 7d9442f)

Co-authored-by: Adam Turner <[email protected]>
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
@AA-Turner @diegorusso
pythongh-128446: Run Windows CI tests on each commit (python#131702)
da18233
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@zanieb zanieb zanieb approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AA-Turner @hugovk @zanieb
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.