GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: fix UBSan failures for `anextawaitableobject` by picnixz · Pull Request #131609 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Mar 23, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
picnixz added 3 commits March 20, 2025 15:21
@picnixz
fix UBSan failures for anextawaitableobject
f7ee5c2
@picnixz
fix UBSan failures for calliterobject
951fcdc
@picnixz
Merge remote-tracking branch 'upstream/main' into fix/ubsan/iterobjec…
b7bce44 
…t-111178
@picnixz picnixz added the skip news label Mar 23, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 23, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 23, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
vstinner
vstinner reviewed Mar 24, 2025
View reviewed changes
Comment thread Objects/iterobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
amend TODO notes
5cb6efe
vstinner
vstinner approved these changes Mar 24, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Objects/iterobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 24, 2025
@picnixz picnixz mentioned this pull request Mar 24, 2025
anextawaitable_close() should be a METH_NOARGS not METH_VARARGS #131666
Closed
@picnixz
remove unnecessary TODO
59d406c
@picnixz
picnixz enabled auto-merge (squash) March 24, 2025 14:21
vstinner
vstinner approved these changes Mar 24, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
picnixz merged commit 4efe397 into python:main Mar 24, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 24, 2025
@picnixz
picnixz deleted the fix/ubsan/iterobject-111178 branch March 24, 2025 14:53
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
@picnixz @diegorusso
pythongh-111178: fix UBSan failures for anextawaitableobject (pytho…
e4c3acd 
…n#131609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments
@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@picnixz @vstinner @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.