GeezerVison is showing github.com — gh-127146: Fix Emscripten build with --pydebug by hoodmane · Pull Request #131672 · python/cpython
Conversation
hoodmane
commented
Mar 24, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
The deleted logic checks that the sysconfigdata is in a short list, and the list does not allow the d ABI flag to be present so it fails if we build with --with-pydebug. I removed the check because I don't think it is helpful.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
The deleted logic checks that the sysconfigdata is in a short list,
and the list does not allow the `d` ABI flag to be present. I removed
the check because I don't think it is helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Seems reasonable. If the build is generating the wrong sysconfigdata name, other things are going to explode; and with the new error reporting, that's going to be a lot easier to diagnose.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 1, 2025
Removes an explicit check that sysconfigdata naming is correct, in favor of reporting at
runtime with the default mechanisms.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.