GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: Fix function signature in pyexpat.c by vstinner · Pull Request #131674 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 24, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Move _Py_NO_SANITIZE_UNDEFINED macro from faulthandler.c to pyport.h.

  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-111178: Fix function signature in pyexpat.c
ba32cfd 
Move _Py_NO_SANITIZE_UNDEFINED macro from faulthandler.c to pyport.h.
@vstinner vstinner added the skip news label Mar 24, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 24, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 24, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
@vstinner

vstinner commented Mar 24, 2025

Copy link
Copy Markdown
Member Author

cc @picnixz
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz approved these changes Mar 24, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I didn't know about that macro! I was scratching my head on how to change the API without breaking everything but this solution is much cleaner. Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Modules/pyexpat.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/pyexpat.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 24, 2025
@vstinner
Rage against the paranthesis
7d9b0e3
@vstinner
vstinner enabled auto-merge (squash) March 24, 2025 16:59
@vstinner
vstinner merged commit 5fef4ff into python:main Mar 24, 2025
@vstinner
vstinner deleted the ubsan_pyexpat branch March 24, 2025 17:22
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 24, 2025
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
@vstinner @diegorusso
pythongh-111178: Fix function signature in pyexpat.c (python#131674)
1498409 
Move _Py_NO_SANITIZE_UNDEFINED macro from faulthandler.c to pyport.h.
@picnixz picnixz mentioned this pull request Apr 4, 2025
UBSan: runtime undefined behaviours when using -fsanitize=undefined -fno-sanitize-recover #132097
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.