GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-111178: Skip undefined behavior checks in _PyPegen_lookahead() by vstinner · Pull Request #131714 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Mar 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For example, expression_rule() return type is 'expr_ty', whereas _PyPegen_lookahead() uses 'void*'.

  • Issue: UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-111178: Skip undefined behavior checks in _PyPegen_lookahead()
52ca09f 
For example, expression_rule() return type is 'expr_ty', whereas
_PyPegen_lookahead() uses 'void*'.
@vstinner vstinner added the skip news label Mar 25, 2025
@vstinner
vstinner requested review from lysnikolaou and pablogsal as code owners March 25, 2025 12:01
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 25, 2025
UBSan: Calling a function through pointer to incorrect function type is undefined behavior #111178
Closed
@vstinner

vstinner commented Mar 25, 2025

Copy link
Copy Markdown
Member Author

cc @picnixz
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 3796884 into python:main Mar 27, 2025
@vstinner
vstinner deleted the ubsan_pegen branch March 27, 2025 09:04
@bedevere-app bedevere-app Bot removed the awaiting core review label Mar 27, 2025
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
@vstinner @diegorusso
pythongh-111178: Skip undefined behavior checks in _PyPegen_lookahead…
673773a 
…() (python#131714)

For example, expression_rule() return type is 'expr_ty', whereas
_PyPegen_lookahead() uses 'void*'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.