GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-130415: Remove redundant `sym_matches_type` calls in the JIT optimizer by brandtbucher · Pull Request #131778 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Mar 26, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

These should already be narrowed by a previous guard. If we made a mistake somewhere, the asserts inside the body of the if will catch it.

  • Issue: Better constant narrowing in the JIT optimizer #130415

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brandtbucher
Remove redundant type checks in the abstract interpreter
c64b969
@brandtbucher brandtbucher added skip news interpreter-core (Objects, Python, Grammar, and Parser dirs) topic-JIT labels Mar 26, 2025
@brandtbucher brandtbucher self-assigned this Mar 26, 2025
@brandtbucher
brandtbucher requested a review from Fidget-Spinner as a code owner March 26, 2025 21:51
@bedevere-app bedevere-app Bot added the awaiting core review label Mar 26, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 26, 2025
Better constant narrowing in the JIT optimizer #130415
Closed
13 of 17 tasks
Fidget-Spinner
Fidget-Spinner approved these changes Mar 27, 2025
View reviewed changes

@Fidget-Spinner Fidget-Spinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine. After all the uops only occur after a guard.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Mar 27, 2025
@brandtbucher
brandtbucher merged commit 972a295 into python:main Mar 27, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 27, 2025
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
@brandtbucher @diegorusso
pythonGH-130415: Remove redundant sym_matches_type calls in the JIT o…
21a5481 
…ptimizer (pythonGH-131778)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) skip news topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@brandtbucher @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.