GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-126835: Refine constant folding tests in `test_peepholer.py::TestTranforms` by WolframAlph · Pull Request #131826 · python/cpython

Conversation

@WolframAlph

@WolframAlph WolframAlph commented Mar 28, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Refine/cleanup old & new constant folding tests in test_peepholer.py.

  • Issue: Move const folding to the peephole optimizer #126835

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
WolframAlph added 5 commits March 27, 2025 13:29
@WolframAlph
merge unaryop folding tests
c03252c
@WolframAlph
merge binaryop folding tests
2c7b401
@WolframAlph
remove test_constant_folding
9a42166 
`test_constant_folding` scenarios are covered in other more specific tests
@WolframAlph
use explicit naming for constant folding tests in TestTransforms
7b94894
@WolframAlph
group constant folding related tests together in TestTransforms
d5ce5ec
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Mar 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Mar 28, 2025
Move const folding to the peephole optimizer #126835
Open
@iritkatriel iritkatriel added the skip news label Mar 28, 2025
iritkatriel
iritkatriel approved these changes Mar 28, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 28, 2025
@iritkatriel
iritkatriel merged commit 674dbf3 into python:main Mar 28, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 28, 2025
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 1, 2025
@WolframAlph @diegorusso
pythongh-126835: Refine constant folding tests in `test_peepholer.py:…
3a5baca 
…:TestTranforms` (python#131826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@WolframAlph @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.