GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Add a single table as summary to cmath documentation by skirpichev · Pull Request #131887 · python/cpython

Conversation

skirpichev commented Mar 30, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

📚 Documentation preview 📚: https://cpython-previews--131887.org.readthedocs.build/

for reviewers:

like Doc: Add a single table as summary to math documentation #125810 (though, maybe it's not a good idea for cmath module)
on top of gh-125957: sync argument naming in sphinx docs of the cmath and help() #125958
maybe table should be moved right after the first paragraph and before the note (For functions involving branch cuts...)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

skirpichev and others added 6 commits

October 25, 2024 09:12


          pythongh-125957: sync argument naming in sphinx docs of the cmath and…

769c65f

… help()


          + allow cmath.sin(z=1) syntax

f34de6a

In the main:
$ ./python -m timeit -r11 -s 'from cmath import sin;z=1j' 'sin(z)'
1000000 loops, best of 11: 312 nsec per loop

With patch:
$ ./python -m timeit -r11 -s 'from cmath import sin;z=1j' 'sin(z)'
1000000 loops, best of 11: 330 nsec per loop


          Merge branch 'master' into fix-cmath-sig-125957

680e7bf


          Revert second commit

57cc455


          Apply suggestions from code review

ec3754e

Co-authored-by: Bénédikt Tran <[email protected]>


          Merge branch 'master' into fix-cmath-sig-125957

ab38770

bedevere-app Bot added docs

Documentation in the Doc dir

skip news awaiting review labels

Mar 30, 2025

github-project-automation Bot added this to Docs PRs

Mar 30, 2025

github-project-automation Bot moved this to Todo in Docs PRs

Mar 30, 2025

skirpichev added skip issue needs backport to 3.12

only security fixes

needs backport to 3.13 only security fixes labels

Mar 30, 2025


          Add a single table as summary to cmath documentation

7878c08

skirpichev force-pushed the cmath.rst-tables branch from dfdcc5f to 7878c08 Compare

March 30, 2025 04:39

StanFromIreland reviewed

Mar 30, 2025

View reviewed changes

Comment thread

Doc/library/cmath.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/cmath.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/cmath.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

skirpichev and others added 2 commits

March 30, 2025 12:37


          Apply suggestions from code review

eac84ff

Co-authored-by: Stan Ulbrych <[email protected]>


          Merge branch 'main' into cmath.rst-tables

2660f9d

AA-Turner approved these changes

Apr 1, 2025

View reviewed changes

Comment thread

Doc/library/cmath.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot added awaiting merge and removed awaiting review labels

Apr 1, 2025

skirpichev commented

Apr 1, 2025

View reviewed changes

Comment thread

Doc/library/cmath.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

python-cla-bot Bot commented Apr 6, 2025

Copy link

Copy Markdown

All commit authors signed the Contributor License Agreement.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Remove backslash

3877f29

Co-authored-by: Sergey B Kirpichev <[email protected]>

hugovk approved these changes

Apr 6, 2025

View reviewed changes

Comment thread

Doc/library/cmath.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/library/cmath.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

AA-Turner and others added 2 commits

April 6, 2025 21:51


          tau spacing

bc04593

Co-authored-by: Hugo van Kemenade <[email protected]>


          remove full stop

18c6098

Co-authored-by: Hugo van Kemenade <[email protected]>

AA-Turner merged commit 6eaa4ae into python:main

Apr 6, 2025

github-project-automation Bot moved this from Todo to Done in Docs PRs

Apr 6, 2025

bedevere-app Bot removed the awaiting merge label

Apr 6, 2025

miss-islington-app Bot commented Apr 6, 2025

Copy link

Copy Markdown

Thanks @skirpichev for the PR, and @AA-Turner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 6, 2025


          Docs: Add a single table summary for cmath (pythonGH-131887)

8a6579e

(cherry picked from commit 6eaa4ae)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Apr 6, 2025


          Docs: Add a single table summary for cmath (pythonGH-131887)

edbafe3

(cherry picked from commit 6eaa4ae)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>

bedevere-app Bot commented Apr 6, 2025

Copy link

Copy Markdown

GH-132179 is a backport of this pull request to the 3.13 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.13 only security fixes label

Apr 6, 2025

bedevere-app Bot commented Apr 6, 2025

Copy link

Copy Markdown

GH-132180 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Apr 6, 2025

AA-Turner added a commit that referenced this pull request

Apr 6, 2025


          [3.13] Docs: Add a single table summary for cmath (GH-131887) (#1…

2f1fc0f

…32179)

Docs: Add a single table summary for ``cmath`` (GH-131887)
(cherry picked from commit 6eaa4ae)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>

AA-Turner added a commit that referenced this pull request

Apr 6, 2025


          [3.12] Docs: Add a single table summary for cmath (GH-131887) (#1…

0c429ac

…32180)

Docs: Add a single table summary for ``cmath`` (GH-131887)
(cherry picked from commit 6eaa4ae)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>

skirpichev deleted the cmath.rst-tables branch

April 7, 2025 01:46

Reviewers

StanFromIreland

StanFromIreland left review comments

hugovk

hugovk approved these changes

AA-Turner

AA-Turner approved these changes

+1 more reviewer

XuehaiPan

XuehaiPan left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip issue skip news

Projects

Docs PRs

Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

skirpichev commented Mar 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

python-cla-bot Bot commented Apr 6, 2025

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Apr 6, 2025

Uh oh!

bedevere-app Bot commented Apr 6, 2025

Uh oh!

bedevere-app Bot commented Apr 6, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

skirpichev commented Mar 30, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.