GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-131498: manage stacks automatically by markshannon · Pull Request #132074 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Apr 4, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is the final preparatory PR for top-of-stack caching

This PR:

  • Removes the stack manipulation macros. Instructions must declare values as dead, and let the code generator pop them from the stack
  • Updates the instrumented instructions to be explicit about their stack effect
  • Supports mixing of scalars and arrays on the stack. The code generator pushes scalars to memory if needed for an array.
  • Issue: Top-of-stack caching in the interpreter #131498

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 7 commits April 3, 2025 10:50
@markshannon
Force stack to memory and clear logical stack if mismatch
ff2cb21
@markshannon
TOS caching for the interpreter. Work in progress.
7509764
@markshannon
Initialize sub-stack slot on non-debug builds as well
492df4e
@markshannon
Remove TOS caching parts
234cfd2
@markshannon
Fixup generated cases test
ba530f6
@markshannon
Remove stack manipulation macros
937ea32
@markshannon
Remove incorrect comment
d57724d
@markshannon markshannon added the skip news label Apr 4, 2025
@markshannon
markshannon requested a review from Fidget-Spinner as a code owner April 4, 2025 13:08
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 4, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 4, 2025
Top-of-stack caching in the interpreter #131498
Closed
markshannon added 2 commits April 4, 2025 14:12
@markshannon
Fix type annotation
f6e0395
@markshannon
Mark false positive
8132b98
iritkatriel
iritkatriel approved these changes Apr 4, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 4, 2025
StanFromIreland
StanFromIreland reviewed Apr 4, 2025
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland
StanFromIreland reviewed Apr 4, 2025
View reviewed changes
Comment thread Python/stackrefs.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@markshannon @StanFromIreland
Apply suggestions from code review
4f8fa37 
Co-authored-by: Stan Ulbrych <[email protected]>
@markshannon

markshannon commented Apr 4, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

The MSVC tail calling interpreter failure seems unrelated to this PR.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@markshannon
markshannon merged commit 7099c75 into python:main Apr 4, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 4, 2025
@markshannon
markshannon deleted the code-gen-handle-stacks branch April 4, 2025 17:09
picnixz pushed a commit to picnixz/cpython that referenced this pull request Apr 5, 2025
@markshannon @picnixz
pythonGH-131498: Cases generator: manage stacks automatically (python…
0b437c4 
…GH-132074)
hpagvn87
hpagvn87 approved these changes Jun 25, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@iritkatriel iritkatriel iritkatriel approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
+1 more reviewer
@hpagvn87 hpagvn87 hpagvn87 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @iritkatriel @StanFromIreland @hpagvn87
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.