GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-87790: support thousands separators for formatting fractional part of Decimal by skirpichev · Pull Request #132202 · python/cpython

Conversation

skirpichev commented Apr 7, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Add underscore as a decimal separator for string formatting #87790

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-87790: support thousands separators for formatting fractiona…

9cac451

…l part of Decimal's

bedevere-app Bot added the awaiting review label

Apr 7, 2025

bedevere-app Bot mentioned this pull request

Apr 7, 2025

Add underscore as a decimal separator for string formatting #87790

Closed

skirpichev added 2 commits

April 17, 2025 08:34


          Merge branch 'master' into frac-sep-Decimal/87790

40e1647


          Merge branch 'main' into frac-sep-Decimal/87790

164bdf8

skirpichev requested review from picnixz and serhiy-storchaka

July 3, 2025 08:00

serhiy-storchaka reviewed

Jul 3, 2025

View reviewed changes

Comment thread

Lib/_pydecimal.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_decimal.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Lib/test/test_decimal.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

skirpichev and others added 3 commits

July 3, 2025 15:10


          Update Lib/_pydecimal.py

387090a

Co-authored-by: Serhiy Storchaka <[email protected]>


          Merge branch 'master' into frac-sep-Decimal/87790

02f0b3d


          address review: test error for _6f

51592d4

skirpichev requested a review from serhiy-storchaka

July 3, 2025 12:41


          address review: fix .6_f test (enlarge integer part)

0353e99

serhiy-storchaka approved these changes

Jul 3, 2025

View reviewed changes

serhiy-storchaka left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting review labels

Jul 3, 2025

serhiy-storchaka requested a review from hugovk

July 3, 2025 13:27

serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label

Jul 3, 2025

hugovk changed the title ~~gh-87790: support thousands separators for formatting fractional part of Decimal's~~ gh-87790: support thousands separators for formatting fractional part of Decimal

Jul 7, 2025

hugovk merged commit 90a5b44 into python:main

Jul 7, 2025

bedevere-app Bot removed the awaiting merge label

Jul 7, 2025

miss-islington-app Bot commented Jul 7, 2025

Copy link

Copy Markdown

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot commented Jul 7, 2025

Copy link

Copy Markdown

Sorry, @skirpichev and @hugovk, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 90a5b4402bc6b8f44a9fe9a5299721b1887b50f8 3.14

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington-app Bot assigned hugovk

Jul 7, 2025

skirpichev deleted the frac-sep-Decimal/87790 branch

July 7, 2025 08:59

serhiy-storchaka added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels

Jul 7, 2025

miss-islington-app Bot commented Jul 7, 2025

Copy link

Copy Markdown

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 7, 2025


          pythongh-87790: support thousands separators for formatting fractiona…

024631b

…l part of Decimal (pythonGH-132202)

(cherry picked from commit 90a5b44)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-app Bot commented Jul 7, 2025

Copy link

Copy Markdown

GH-136365 is a backport of this pull request to the 3.14 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label

Jul 7, 2025

hugovk pushed a commit that referenced this pull request

Jul 7, 2025


          [3.14] gh-87790: support thousands separators for formatting fraction…

e255313

…al part of Decimal (GH-132202) (#136365)

Co-authored-by: Sergey B Kirpichev <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>

AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request

Jul 11, 2025


          pythongh-87790: support thousands separators for formatting fractiona…

…l part of Decimal (python#132202)

Co-authored-by: Serhiy Storchaka <[email protected]>

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request

Jul 12, 2025


          pythongh-87790: support thousands separators for formatting fractiona…

b2fb355

…l part of Decimal (python#132202)

Co-authored-by: Serhiy Storchaka <[email protected]>

picnixz pushed a commit to picnixz/cpython that referenced this pull request

Jul 13, 2025


          pythongh-87790: support thousands separators for formatting fractiona…

d56b35a

…l part of Decimal (python#132202)

Co-authored-by: Serhiy Storchaka <[email protected]>

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request

Aug 4, 2025


          pythongh-87790: support thousands separators for formatting fractiona…

909ed0a

…l part of Decimal (python#132202)

Co-authored-by: Serhiy Storchaka <[email protected]>

Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request

Aug 19, 2025


          pythongh-87790: support thousands separators for formatting fractiona…

6e437ca

…l part of Decimal (python#132202)

Co-authored-by: Serhiy Storchaka <[email protected]>

Reviewers

serhiy-storchaka

serhiy-storchaka approved these changes

picnixz

Awaiting requested review from picnixz

hugovk

Awaiting requested review from hugovk

Uh oh!

There was an error while loading. Please reload this page.

Assignees

hugovk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

skirpichev commented Apr 7, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Jul 7, 2025

Uh oh!

miss-islington-app Bot commented Jul 7, 2025

Uh oh!

miss-islington-app Bot commented Jul 7, 2025

Uh oh!

bedevere-app Bot commented Jul 7, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

skirpichev commented Apr 7, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.