GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131507: Remove Misc/mypy symlinks from the repository by ambv · Pull Request #132270 · python/cpython

Conversation

@ambv

@ambv ambv commented Apr 8, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

They would end up in source tarballs and consequently in the SBOM. We don't want that.

  • Issue: Syntax highlighting in PyREPL #131507

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ambv
Remove Misc/mypy symlinks from the repository
6db21b1 
They would end up in source tarballs and consequently in the SBOM. We don't
want that.
@ambv
ambv requested review from AA-Turner, erlend-aasland, ezio-melotti and hugovk as code owners April 8, 2025 13:35
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 8, 2025
@ambv ambv changed the title Remove Misc/mypy symlinks from the repository gh-131507: Remove Misc/mypy symlinks from the repository Apr 8, 2025
@ambv ambv added the skip news label Apr 8, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 8, 2025
Syntax highlighting in PyREPL #131507
Closed
Yhg1s
Yhg1s approved these changes Apr 8, 2025
View reviewed changes
Comment thread Misc/mypy/.gitignore
@@ -0,0 +1,5 @@
# This list is also used in make_symlinks.py, only put actual concrete paths below

@Yhg1s Yhg1s Apr 8, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a pity .gitignore doesn't let you include other files.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Misc/mypy/README.md
operating systems without symlink support. Additionally, those symlinks
would have to be part of the SBOM, which we don't want either.

Instead, this directory ships with a `make_symlinks.py` script, which

@Yhg1s Yhg1s Apr 8, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, I would be inclined to not symlink anything, and instead copy files to a separate directory to run mypy on... but then I don't use mypy and I have no idea how that would integrate with normal edit-typecheck workflows people have.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ambv ambv Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copying files makes it annoying for a local workflow since then you have to copy the tree for every mypy run. that's too slow.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 8, 2025
@ambv ambv mentioned this pull request Apr 8, 2025
gh-131507: Add a way to recreate the Misc/mypy symlinks if missing #132274
Merged
@ambv ambv closed this Apr 8, 2025
@ambv

ambv commented Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

I'm going with #132274 instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv deleted the remove-symlinks-from-repo branch May 5, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Yhg1s approved these changes
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ambv @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.