GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131507: Add a way to recreate the `Misc/mypy` symlinks if missing by ambv · Pull Request #132274 · python/cpython

Conversation

@ambv

@ambv ambv commented Apr 8, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

They will be removed in source tarballs so they don't appear in the SBOM.

This is an alternative to #132270 that keeps the symlinks in the repository. This has the following advantages:

  • the list of the modules isn't stored in a .gitignore file;
  • any mypy.ini configuration files that add the Misc/mypy directory can be used in a local type-checking workflow without running any additional tools.

This allows running type checking without building Python first or running the additional script manually. This is important because the type-checking errors emitted due to missing symlinks are confusing and don't suggest what the solution is.

The only disadvantage of this PR compared to #132270 is that we still keep symlinks in the repository 🤷🏻‍♂️

  • Issue: Syntax highlighting in PyREPL #131507

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ambv
Add a way to recreate the Misc/mypy symlinks
987b04a 
They will be removed in source tarballs so they don't appear
in the SBOM.
@ambv
ambv requested review from AA-Turner, ezio-melotti and hugovk as code owners April 8, 2025 14:31
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 8, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 8, 2025
Syntax highlighting in PyREPL #131507
Closed
@ambv ambv added the skip news label Apr 8, 2025
@ambv ambv mentioned this pull request Apr 8, 2025
gh-131507: Remove Misc/mypy symlinks from the repository #132270
Closed
@ambv ambv added the needs backport to 3.13 only security fixes label Apr 8, 2025
StanFromIreland
StanFromIreland reviewed Apr 8, 2025
View reviewed changes
Comment thread Misc/mypy/typed-stdlib.txt Resolved

Uh oh!

There was an error while loading. Please reload this page.
@ambv @StanFromIreland
Update Misc/mypy/typed-stdlib.txt
e82534d 
Co-authored-by: Stan Ulbrych <[email protected]>
@ambv
ambv force-pushed the keep-symlinks-in-repo branch from e82534d to 987b04a Compare April 8, 2025 17:31
@ambv

ambv commented Apr 8, 2025

Copy link
Copy Markdown
Contributor Author

(I undid the mistaken force-push, but there's no log entry about that happening.)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes Apr 8, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 8, 2025
@ambv
ambv merged commit 16dcb57 into python:main Apr 8, 2025
@miss-islington-app

miss-islington-app Bot commented Apr 8, 2025

Copy link
Copy Markdown

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 8, 2025
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 8, 2025
@ambv @StanFromIreland @miss-islington
pythongh-131507: Add a way to recreate the Misc/mypy symlinks if mi…
072fb2e 
…ssing (pythonGH-132274)

They will be removed in source tarballs so they don't appear
in the SBOM.
(cherry picked from commit 16dcb57)

Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 8, 2025

Copy link
Copy Markdown

GH-132293 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 8, 2025
ambv added a commit that referenced this pull request Apr 8, 2025
@miss-islington @ambv @StanFromIreland
[3.13] gh-131507: Add a way to recreate the Misc/mypy symlinks if m…
099b301 
…issing (GH-132274) (#132293)

They will be removed in source tarballs so they don't appear in the SBOM.

(cherry picked from commit 16dcb57)

Co-authored-by: Łukasz Langa <[email protected]>
Co-authored-by: Stan Ulbrych <[email protected]>
@ambv
ambv deleted the keep-symlinks-in-repo branch May 5, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@pablogsal pablogsal pablogsal approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ambv @pablogsal @StanFromIreland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.