GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] GH-127682: Backport GH-132351 by markshannon · Pull Request #132384 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Apr 11, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Regression of 3.13.1 with iterator creation being duplicated #127682

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
pythonGH-127682: Only call __iter__ once in generator expressions. (p…
a226707 
…ythonGH-132351)
@markshannon
markshannon requested a review from iritkatriel as a code owner April 11, 2025 08:53
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 11, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 11, 2025
Regression of 3.13.1 with iterator creation being duplicated #127682
Closed
iritkatriel
iritkatriel approved these changes Apr 29, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 29, 2025
@markshannon
markshannon merged commit 132bdf6 into python:3.13 Apr 29, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 29, 2025
@Roman513 Roman513 mentioned this pull request Jun 5, 2025
Generator expression behavior changed in 3.13.4 - it does not throw exception anymore #135171
Closed
@Yhg1s

Yhg1s commented Jun 5, 2025

Copy link
Copy Markdown
Member

Looks like this changes behaviour in a couple of subtle ways (see #135171) and it's not suitable for backport. I'm not sure if the changed behaviour is suitable for 3.14, but I'll leave that to @hugovk to investigate ;p
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Roman513

Roman513 commented Jun 5, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Maybe it worth to check later if alternative closed PR from @efimov-mikhail has better handling of this for such cases: #126408 - at least for 3.14.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s added a commit to Yhg1s/cpython that referenced this pull request Jun 11, 2025
@Yhg1s
Roll back commits c6af7f4 (pythonGH-134799),
15beb57 
814ac0d (pythonGH-134788) and
132bdf6 (pythonGH-132384), which changed bytecode
(not allowed in patch releases) and semantics (also problematic in patch
releases). This reopens pythonGH-127682 as an issue.
@Yhg1s Yhg1s mentioned this pull request Jun 11, 2025
[3.13] GH-135171: Roll back all fixes for GH-127682 as they are not suitable for 3.13 #135390
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @Yhg1s @Roman513 @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.