GeezerVison

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

Just to update the status:

I have made the requested changes; please review again

Thanks for making the requested changes!

@brandtbucher: please review the changes made to this pull request.

I added the test you suggested since it was quite easy to do :)

Also, should we care about the compiler warnings I mentioned in the PR description? There are now two unused variable warnings:

In file included from Python/ceval.c:1121:
Python/executor_cases.c.h: In function ‘_PyEval_EvalFrameDefault’:
Python/executor_cases.c.h:5142:25: warning: variable ‘callable’ set but not used [-Wunused-but-set-variable]
 5142 |             _PyStackRef callable;
      |                         ^~~~~~~~
Python/executor_cases.c.h:5141:25: warning: variable ‘null’ set but not used [-Wunused-but-set-variable]
 5141 |             _PyStackRef null;
      |                         ^~~~

Yeah, we should fix those. Can you rename them to unused, and remove the two DEAD calls, and add an INPUTS_DEAD() call at the very end, after the arg is closed?

Yeah, we should fix those. Can you rename them to unused, and remove the two DEAD calls, and add an INPUTS_DEAD() call at the very end, after the arg is closed?

it's getting a bit late here so maybe I missed something, but I'm getting SyntaxError: Input 'null' is still live when output 'res' is defined. FTR, this is what I did:

diff --git a/Python/bytecodes.c b/Python/bytecodes.c
index 22bb4097611..129e606bde2 100644
--- a/Python/bytecodes.c
+++ b/Python/bytecodes.c
@@ -3969,15 +3969,14 @@ dummy_func(
             DEOPT_IF(callable_o != (PyObject *)&PyType_Type);
         }
 
-        op(_CALL_TYPE_1, (callable, null, arg -- res)) {
+        op(_CALL_TYPE_1, (unused, unused, arg -- res)) {
             PyObject *arg_o = PyStackRef_AsPyObjectBorrow(arg);
 
             assert(oparg == 1);
-            DEAD(null);
-            DEAD(callable);
             STAT_INC(CALL, hit);
             res = PyStackRef_FromPyObjectNew(Py_TYPE(arg_o));
             PyStackRef_CLOSE(arg);
+            INPUTS_DEAD();
         }
 
         macro(CALL_TYPE_1) =

How about we add

(void)null;
(void)callable;

I've seen it used in some other instructions. Not sure whether it's the best fix but it does get rid of the warnings.