GeezerVison is showing github.com — GH-131498: Replace single-element arrays with scalars in `bytecodes.c` by brandtbucher · Pull Request #132615 · python/cpython
Conversation
Also, mark some unused items as unused (and fix a bug in the cases generator that sometimes disallowed multiple unused names to occur in the same instruction).
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
brandtbucher
changed the title
GH-131498: Replace uses of array[1]s with scalars in bytecode definitions
GH-131498: Replace uses of single-element arrays with scalars in bytecodes.c
Apr 16, 2025
brandtbucher
changed the title
GH-131498: Replace uses of single-element arrays with scalars in bytecodes.c
GH-131498: Replace single-element arrays with scalars in bytecodes.c
Apr 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️
Hi! The buildbot aarch64 Android 3.x (tier-3) has failed when building commit 40ae889.
What do you need to do:
- Don't panic.
- Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
- Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1594/builds/1983) and take a look at the build logs.
- Check if the failure is related to this commit (40ae889) or if it is a false positive.
- If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.
You can take a look at the buildbot page here:
https://buildbot.python.org/#/builders/1594/builds/1983
Summary of the results of the build (if available):
Click to see traceback logs
remote: Enumerating objects: 27, done.
remote: Counting objects: 3% (1/27)
remote: Counting objects: 7% (2/27)
remote: Counting objects: 11% (3/27)
remote: Counting objects: 14% (4/27)
remote: Counting objects: 18% (5/27)
remote: Counting objects: 22% (6/27)
remote: Counting objects: 25% (7/27)
remote: Counting objects: 29% (8/27)
remote: Counting objects: 33% (9/27)
remote: Counting objects: 37% (10/27)
remote: Counting objects: 40% (11/27)
remote: Counting objects: 44% (12/27)
remote: Counting objects: 48% (13/27)
remote: Counting objects: 51% (14/27)
remote: Counting objects: 55% (15/27)
remote: Counting objects: 59% (16/27)
remote: Counting objects: 62% (17/27)
remote: Counting objects: 66% (18/27)
remote: Counting objects: 70% (19/27)
remote: Counting objects: 74% (20/27)
remote: Counting objects: 77% (21/27)
remote: Counting objects: 81% (22/27)
remote: Counting objects: 85% (23/27)
remote: Counting objects: 88% (24/27)
remote: Counting objects: 92% (25/27)
remote: Counting objects: 96% (26/27)
remote: Counting objects: 100% (27/27)
remote: Counting objects: 100% (27/27), done.
remote: Compressing objects: 10% (1/10)
remote: Compressing objects: 20% (2/10)
remote: Compressing objects: 30% (3/10)
remote: Compressing objects: 40% (4/10)
remote: Compressing objects: 50% (5/10)
remote: Compressing objects: 60% (6/10)
remote: Compressing objects: 70% (7/10)
remote: Compressing objects: 80% (8/10)
remote: Compressing objects: 90% (9/10)
remote: Compressing objects: 100% (10/10)
remote: Compressing objects: 100% (10/10), done.
remote: Total 14 (delta 13), reused 4 (delta 4), pack-reused 0 (from 0)
From https://github.com/python/cpython
* branch main -> FETCH_HEAD
Note: switching to '40ae88988c61638ee8625e5c0ee73606ede307bb'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 40ae88988c6 GH-131498: Replace single-element arrays with scalars in bytecodes.c (GH-132615)
Switched to and reset branch 'main'
configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.
In file included from ../../Python/ceval.c:1061:
../../Python/generated_cases.c.h:12125:13: warning: code will never be executed [-Wunreachable-code]
12125 | stack_pointer -= 3;
| ^~~~~~~~~~~~~
../../Python/generated_cases.c.h:12118:13: warning: code will never be executed [-Wunreachable-code]
12118 | stack_pointer -= 4;
| ^~~~~~~~~~~~~
../../Python/generated_cases.c.h:7435:13: warning: code will never be executed [-Wunreachable-code]
7435 | stack_pointer += -1;
| ^~~~~~~~~~~~~
3 warnings generated.
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 192k 100 192k 0 0 1716k 0 --:--:-- --:--:-- --:--:-- 1716k
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 42455 100 42455 0 0 389k 0 --:--:-- --:--:-- --:--:-- 389k
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 5041k 100 5041k 0 0 24.7M 0 --:--:-- --:--:-- --:--:-- 24.7M
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 1252k 100 1252k 0 0 9281k 0 --:--:-- --:--:-- --:--:-- 9281k
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
100 635k 100 635k 0 0 5363k 0 --:--:-- --:--:-- --:--:-- 5363k
../../configure: line 4059: pkg-config: command not found
configure: WARNING: no system libmpdecimal found; falling back to bundled libmpdecimal (deprecated and scheduled for removal in Python 3.15)
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.
In file included from ../../Python/ceval.c:1061:
../../Python/generated_cases.c.h:12125:13: warning: code will never be executed [-Wunreachable-code]
12125 | stack_pointer -= 3;
| ^~~~~~~~~~~~~
../../Python/generated_cases.c.h:12118:13: warning: code will never be executed [-Wunreachable-code]
12118 | stack_pointer -= 4;
| ^~~~~~~~~~~~~
../../Python/generated_cases.c.h:7435:13: warning: code will never be executed [-Wunreachable-code]
7435 | stack_pointer += -1;
| ^~~~~~~~~~~~~
../../Python/fileutils.c:460:1: warning: unused function 'decode_current_locale' [-Wunused-function]
460 | decode_current_locale(const char* arg, wchar_t **wstr, size_t *wlen,
| ^~~~~~~~~~~~~~~~~~~~~
../../Python/fileutils.c:679:1: warning: unused function 'encode_current_locale' [-Wunused-function]
679 | encode_current_locale(const wchar_t *text, char **str,
| ^~~~~~~~~~~~~~~~~~~~~
2 warnings generated.
3 warnings generated.
../../Modules/_localemodule.c:148:1: warning: unused function 'is_all_ascii' [-Wunused-function]
148 | is_all_ascii(const char *str)
| ^~~~~~~~~~~~
1 warning generated.
../../Modules/_hacl/Lib_Memzero0.c:52:6: warning: "Your platform does not support any safe implementation of memzero -- consider a pull request!" [-W#warnings]
52 | #warning "Your platform does not support any safe implementation of memzero -- consider a pull request!"
| ^
../../Modules/_hacl/Lib_Memzero0.c:40:10: warning: unused variable 'len_' [-Wunused-variable]
40 | size_t len_ = (size_t) len;
| ^~~~
2 warnings generated.
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0
curl: (56) Recv failure: Connection reset by peer
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
Fidget-Spinner
Awaiting requested review from Fidget-Spinner
Fidget-Spinner is a code owner
Uh oh!
There was an error while loading. Please reload this page.
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|