GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132435: Test syntax warnings in a `finally` block by tomasr8 · Pull Request #132436 · python/cpython

Conversation

@tomasr8

@tomasr8 tomasr8 commented Apr 12, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Test syntax warnings emitted in a finally block #132435

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Brett2148 reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@tomasr8
Test syntax warnings in a finally block
946788f
@tomasr8 tomasr8 added the skip news label Apr 12, 2025
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Apr 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 12, 2025
Test syntax warnings emitted in a finally block #132435
Closed
@tomasr8 tomasr8 mentioned this pull request Apr 12, 2025
gh-131927: Prevent emitting optimizer warnings twice in the REPL #131993
Merged
@tomasr8
tomasr8 requested a review from serhiy-storchaka April 12, 2025 12:59
serhiy-storchaka
serhiy-storchaka reviewed Apr 12, 2025
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tomasr8 reacted with rocket emoji
All reactions
  • 🚀 1 reaction
Eclips4
Eclips4 approved these changes Apr 12, 2025
View reviewed changes

@Eclips4 Eclips4 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 12, 2025
sobolevn
sobolevn reviewed Apr 12, 2025
View reviewed changes
Comment thread Lib/test/test_compile.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tomasr8
Improve test
6b0c13c
@tomasr8
tomasr8 requested a review from sobolevn April 12, 2025 21:27
sobolevn
sobolevn approved these changes Apr 12, 2025
View reviewed changes
@sobolevn

sobolevn commented Apr 12, 2025

Copy link
Copy Markdown
Member

Do we need to backport this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
sobolevn enabled auto-merge (squash) April 12, 2025 21:30
@tomasr8

tomasr8 commented Apr 12, 2025

Copy link
Copy Markdown
Member Author

I would, once #131993 is backported as well.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4

Eclips4 commented Apr 13, 2025

Copy link
Copy Markdown
Member

CI seems stuck. Merging main to restart it.
tomasr8 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Eclips4
Merge branch 'main' into finally-warning
0fdf193
@tomasr8

tomasr8 commented Apr 13, 2025

Copy link
Copy Markdown
Member Author

The multiprocessing test failures (ENV_CHANGED) do not seem related. I've also seen them fail on other PRs recently
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka disabled auto-merge April 13, 2025 08:22
@serhiy-storchaka serhiy-storchaka removed the skip news label Apr 13, 2025
@serhiy-storchaka

serhiy-storchaka commented Apr 13, 2025

Copy link
Copy Markdown
Member

While we are here, please add a NEWS entry about emitting compiler warnings twice. This is a user visible change, and can save a day for somebody.
tomasr8 and Eclips4 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tomasr8
Add news entry
b3db7ed
serhiy-storchaka
serhiy-storchaka approved these changes Apr 13, 2025
View reviewed changes
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) April 13, 2025 08:38
@tomasr8 tomasr8 added the needs backport to 3.13 only security fixes label Apr 13, 2025
@serhiy-storchaka
serhiy-storchaka merged commit 887eabc into python:main Apr 13, 2025
@miss-islington-app

miss-islington-app Bot commented Apr 13, 2025

Copy link
Copy Markdown

Thanks @tomasr8 for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 13, 2025
@miss-islington-app

miss-islington-app Bot commented Apr 13, 2025

Copy link
Copy Markdown

Sorry, @tomasr8 and @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 887eabc5a74316708460120d60d0fa4f8bdf5960 3.13
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington-app miss-islington-app Bot assigned serhiy-storchaka Apr 13, 2025
@tomasr8
tomasr8 deleted the finally-warning branch April 13, 2025 20:51
@tomasr8

tomasr8 commented Apr 13, 2025

Copy link
Copy Markdown
Member Author

I can backport this tomorrow, unless you beat me to it
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Apr 13, 2025

Copy link
Copy Markdown
Member

It is a midnight here, so I'll be AFK for next 9-10 hours.
tomasr8 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app

bedevere-app Bot commented Apr 14, 2025

Copy link
Copy Markdown

GH-132503 is a backport of this pull request to the 3.13 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.13 only security fixes label Apr 14, 2025
serhiy-storchaka pushed a commit that referenced this pull request Apr 14, 2025
@tomasr8
[3.13] gh-132435: Test syntax warnings in a finally block (GH-132436) (…
5f1eaff 
…GH-132503)

(cherry picked from commit 887eabc)
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@sobolevn sobolevn sobolevn approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tomasr8 @sobolevn @Eclips4 @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.