GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — gh-105895: Add `match` and `case` to `help` topics by dzherb · Pull Request #132784 · python/cpython Conversation
|
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I'm not sure if I should also commit the autogenerated |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
This test case fails not due to unsorted keywords, but because class TestHelper(unittest.TestCase): def test_keywords(self): self.assertEqual(sorted(pydoc.Helper.keywords), sorted(keyword.kwlist)) I suggest splitting this into two separate cases: class TestHelper(unittest.TestCase): def test_keywords_are_sorted(self): self.assertEqual( sorted(pydoc.Helper.keywords), list(pydoc.Helper.keywords), ) def test_keywords_in_grammar(self): all_keywords = set(keyword.kwlist) | set(keyword.softkwlist) for kw in pydoc.Helper.keywords: self.assertIn(kw, all_keywords) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I checked out this PR and tried:
I think that you need to regen pydoc-topics with: make -C Doc pydoc-topics
It might take a while.
Also, add a NEWS entry (see #132784 (comment) about how to do that) and change the issue number :) I will update you PR title for you to match the original issue #132783
Sorry, something went wrong.
There was an error while loading. Please reload this page.
match and case to help topicsmatch and case to help topics
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
# Conflicts: # Lib/pydoc_data/topics.py
|
@sobolevn could you please look at the last changes? Is everything ok? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I can't merge this PR. Since I am not an expert in pydoc and I need someone who knows how it actually works to verify :)
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
There are conflicts that need to be fixed.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Please revert changes to this file, they will be automatically done before a release.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Please move to "Library"
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This PR is stale because it has been open for 30 days with no activity. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Closing, changes haven't been made. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I will take this over and credit @dzherb for their work :) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Originally published in python#132784 Co-authored-by: dzherb <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.