GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91048: Chain some exceptions in _testexternalinspection.c by sergey-miryanov · Pull Request #132970 · python/cpython

Conversation

@sergey-miryanov

@sergey-miryanov sergey-miryanov commented Apr 25, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  1. Added extra Py_UNREACHABLE calls on unsupported platforms
  2. Remove unused refcnt read
  3. Set result to 0 if fd closing failed
  4. Chain some exceptions to get more info if failed
  • Issue: Async Call-Stack Reconstruction #91048

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sergey-miryanov added 5 commits April 26, 2025 00:51
@sergey-miryanov
Add Py_UNREACHABLE
0664231
@sergey-miryanov
Remove unused refcnt
cd9a499
@sergey-miryanov
Reset result if can not close file descriptor
3ed2837
@sergey-miryanov
Set exception only if not set
cc46cc2
@sergey-miryanov
Chain exception to get more info
6a72bf9
@sergey-miryanov sergey-miryanov changed the title Chain some exceptions in _testexternalinspection.c gh-91048: Chain some exceptions in _testexternalinspection.c Apr 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 25, 2025
Async Call-Stack Reconstruction #91048
Closed
picnixz
picnixz reviewed Apr 25, 2025
View reviewed changes
Comment thread Modules/_testexternalinspection.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
sergey-miryanov added 3 commits April 26, 2025 01:11
@sergey-miryanov
Remove error string from macos impl to keep PermissionError
6466cf9
@sergey-miryanov
Replace macro with static function
e718330
@sergey-miryanov
Remove chain_exceptions from remote_debug to make clang on macos happy
40e099b 
- I believe it is not worth to add conditional compilation of
  such small function like chain_exceptions
@sergey-miryanov
sergey-miryanov marked this pull request as ready for review April 25, 2025 21:00
@bedevere-app bedevere-app Bot added the awaiting review label Apr 25, 2025
@sergey-miryanov

sergey-miryanov commented Apr 25, 2025

Copy link
Copy Markdown
Contributor Author

@pablogsal Please take a look.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pablogsal
pablogsal approved these changes May 2, 2025
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is a great improvement. Thanks a lot!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sergey-miryanov reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 2, 2025
pablogsal
pablogsal approved these changes May 2, 2025
View reviewed changes
@pablogsal pablogsal added the skip news label May 2, 2025
@pablogsal
pablogsal merged commit bd2ed7c into python:main May 2, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 2, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sergey-miryanov @Pranjal095
pythongh-91048: Chain some exceptions in _testexternalinspection.c (p…
12e7c87 
…ython#132970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sergey-miryanov @picnixz @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.