GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-133158: Adjust c-analyzer max_sizes for typeobject.c by sergey-miryanov · Pull Request #133159 · python/cpython

Conversation

sergey-miryanov commented Apr 29, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: Increase limits for typeobject.c in c-analyzer #133158

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          Adjust c-analyzer max_sizes for typeobject.c

cec1f7a

sergey-miryanov requested a review from ericsnowcurrently as a code owner

April 29, 2025 16:29

bedevere-app Bot added the awaiting review label

Apr 29, 2025

bedevere-app Bot mentioned this pull request

Apr 29, 2025

Increase limits for typeobject.c in c-analyzer #133158

Closed

sergey-miryanov commented Apr 29, 2025

Copy link

Copy Markdown

Contributor Author

I believe this PR should skip news.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sergey-miryanov commented Apr 29, 2025

Copy link

Copy Markdown

Contributor Author

@ericsnowcurrently Please take a look.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tomasr8 added the skip news label

Apr 29, 2025

sergey-miryanov added 3 commits

May 1, 2025 00:22


          Extend error messages if too much code to c-analyzer

45be756


          Make linter happy

ce4b06c


          Merge branch 'main' into pythongh-133158-adjust-c-analyzer-limits

01d2a21

sergey-miryanov commented Jun 13, 2025

Copy link

Copy Markdown

Contributor Author

@ericsnowcurrently Please take a look as you got time.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sergey-miryanov mentioned this pull request

Jul 22, 2025

The C analyzer seems to fail when --disable-gil is set #136952

Open

ZeroIntensity reviewed

Jul 22, 2025

View reviewed changes

ZeroIntensity left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do my best to review this, but I'm not at all an expert here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Tools/c-analyzer/c_parser/parser/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/c-analyzer/c_parser/parser/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

sergey-miryanov commented Jul 22, 2025

Copy link

Copy Markdown

Contributor Author

@ZeroIntensity Thanks for review!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sergey-miryanov added 3 commits

July 22, 2025 22:10


          Merge branch 'main' into pythongh-133158-adjust-c-analyzer-limits

e492c49


          Address review comments

c514255


          Fix dedent usage

4369d2d

sergey-miryanov commented Jul 22, 2025

Copy link

Copy Markdown

Contributor Author

Command to run (I always forgot it):
.\python.bat Tools/c-analyzer/check-c-globals.py --format summary Objects/typeobject.c

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sergey-miryanov commented Jul 22, 2025

Copy link

Copy Markdown

Contributor Author

Fixed, thanks! It is ready for review.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ZeroIntensity reviewed

Jul 23, 2025

View reviewed changes

Comment thread

Tools/c-analyzer/c_parser/parser/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Tools/c-analyzer/cpython/_parser.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Update Tools/c-analyzer/c_parser/parser/__init__.py

e60d28c

Co-authored-by: Peter Bierma <[email protected]>

ZeroIntensity reviewed

Jul 28, 2025

View reviewed changes

Comment thread

Tools/c-analyzer/c_parser/parser/_info.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

sergey-miryanov added 3 commits

August 1, 2025 23:29


          Merge branch 'main' into pythongh-133158-adjust-c-analyzer-limits

3c40c29


          Rename too_much_lines to too_many_lines

278f4d3


          Merge branch 'pythongh-133158-adjust-c-analyzer-limits' of github.com…

8fc1349

…:sergey-miryanov/cpython into pythongh-133158-adjust-c-analyzer-limits

ZeroIntensity reviewed

Aug 2, 2025

View reviewed changes

Comment thread

Tools/c-analyzer/c_parser/parser/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Move textwrap import to the top

639e005

ZeroIntensity approved these changes

Aug 2, 2025

View reviewed changes

ZeroIntensity left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm going to let this sit for a day or two before merging it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sergey-miryanov reacted with thumbs up emoji

All reactions

👍 1 reaction

bedevere-app Bot added awaiting merge and removed awaiting review labels

Aug 2, 2025

sergey-miryanov commented Aug 2, 2025

Copy link

Copy Markdown

Contributor Author

Thanks for review!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sergey-miryanov commented Sep 2, 2025

Copy link

Copy Markdown

Contributor Author

@ZeroIntensity Friendly ping.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ZeroIntensity commented Sep 2, 2025

Copy link

Copy Markdown

Member

Thanks, forgot about this one. In the future, feel free to tag me sooner if I say I'm going to merge something then don't do it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          Merge branch 'main' into pythongh-133158-adjust-c-analyzer-limits

ff1d028

ZeroIntensity enabled auto-merge (squash)

September 2, 2025 13:09

sergey-miryanov commented Sep 2, 2025

Copy link

Copy Markdown

Contributor Author

In the future, feel free to tag me sooner if I say I'm going to merge something then don't do it.

Ok, thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ZeroIntensity merged commit 33f8910 into python:main

Sep 2, 2025

bedevere-app Bot removed the awaiting merge label

Sep 2, 2025

sergey-miryanov deleted the gh-133158-adjust-c-analyzer-limits branch

September 2, 2025 16:27

lkollar pushed a commit to lkollar/cpython that referenced this pull request

Sep 9, 2025


          pythongh-133158: Adjust c-analyzer max_sizes for typeobject.c (py…

ed0ba1c

…thonGH-133159)

This also improves the error message for when a file is too large.

Reviewers

ZeroIntensity

ZeroIntensity approved these changes

ericsnowcurrently

Awaiting requested review from ericsnowcurrently

ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

sergey-miryanov commented Apr 29, 2025 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sergey-miryanov commented Apr 29, 2025

Uh oh!

sergey-miryanov commented Apr 29, 2025

Uh oh!

sergey-miryanov commented Jun 13, 2025

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sergey-miryanov commented Jul 22, 2025

Uh oh!

sergey-miryanov commented Jul 22, 2025

Uh oh!

sergey-miryanov commented Jul 22, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ZeroIntensity left a comment

Choose a reason for hiding this comment

Uh oh!

sergey-miryanov commented Aug 2, 2025

Uh oh!

sergey-miryanov commented Sep 2, 2025

Uh oh!

ZeroIntensity commented Sep 2, 2025

Uh oh!

sergey-miryanov commented Sep 2, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sergey-miryanov commented Apr 29, 2025 •

edited by bedevere-app Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.