GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-133171: Prevent combinations of `--disable-gil` and `--enable-experimental-jit` (for now) by brandtbucher · Pull Request #133179 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Apr 30, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

...I do not think it means what you think it means.

  • Issue: Make the JIT thread-safe #133171

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 3 commits April 29, 2025 15:34
@brandtbucher
--disable-gil doesn't support --enable-experimental-jit
1076f10
@brandtbucher
blurb add
9b9ff5d
@brandtbucher
Remove JIT/FT CI job
976cdb9
@brandtbucher brandtbucher added build The build process and cross-build topic-free-threading topic-JIT labels Apr 30, 2025
@brandtbucher brandtbucher self-assigned this Apr 30, 2025
@brandtbucher
brandtbucher requested review from a team, corona10, erlend-aasland and savannahostrowski as code owners April 30, 2025 00:17
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 30, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 30, 2025
Make the JIT thread-safe #133171
Open
1 of 7 tasks
@brandtbucher brandtbucher changed the title GH-133171: Prevent combinations of --disable-gil *and* --enable-experimental-jit (for now) GH-133171: Prevent combinations of --disable-gil and --enable-experimental-jit (for now) Apr 30, 2025
@brandtbucher

brandtbucher commented Apr 30, 2025

Copy link
Copy Markdown
Member Author

Probably gonna conflict with GH-131751. @savannahostrowski, you can land that one first.
savannahostrowski reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba
zooba reviewed Apr 30, 2025
View reviewed changes
Comment thread PCbuild/build.bat
)
)

if "%UseDisableGil%" EQU "true" if "%UseTIER2%" NEQ "" (

@zooba zooba Apr 30, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strictly speaking this would be better as target in pythoncore.vcxproj (see the existing _WarnAboutZlib for example), since there's no requirement to use the batch file, and it's very easy to bypass it. (The same goes for the PGO warning above, I don't remember when that was added.)

But it's not a big deal. It's relatively temporary code anyway

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@brandtbucher brandtbucher May 2, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this will only be around for 3.14. I could just put an #error in the C source or whatever, but I figure failing early is best.

Besides, it's not like there's anything wrong with enabling both features. It just doesn't work the way you'd expect.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zooba reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@brandtbucher
Merge branch 'main' into nogil-means-nojit
fd55937
@brandtbucher
brandtbucher merged commit 2da48e3 into python:main May 2, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label May 2, 2025
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@brandtbucher @Pranjal095
pythonGH-133171: Prevent combinations of --disable-gil and --enable-e…
abf043b 
…xperimental-jit... for now (pythonGH-133179)
@corona10 corona10 mentioned this pull request Aug 15, 2025
gh-133171: Re-enable JUMP_BACKWARD to free-threading build #137800
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba zooba left review comments
@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

build The build process and cross-build topic-free-threading topic-JIT

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@brandtbucher @zooba
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.