GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133228: c-analyzer clang preprocessor by dg-pb · Pull Request #133229 · python/cpython

Conversation

@dg-pb

@dg-pb dg-pb commented Apr 30, 2025 •
edited by gpshead
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Few minor deviations from gcc, but all seems to be working correctly.

Changes (apart from main implementation):

  1. MAX_SIZES additions for 2 files were required.
  2. Added a fix for [n]curses.h failures on clang (gcc also includes both markerlines - curses.h and ncurses.h, but a bit differently, thus passes)
  3. Added couple of global ignores that were failing on clang (don't know why they weren't on gcc)
  • Issue: c-analyzer clang preprocessor #133228

Closes #133228

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@dg-pb
impl
488ba78
@dg-pb
dg-pb requested a review from ericsnowcurrently as a code owner April 30, 2025 23:53
@bedevere-app bedevere-app Bot added the awaiting review label Apr 30, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 30, 2025
c-analyzer clang preprocessor #133228
Closed
AA-Turner
AA-Turner reviewed May 1, 2025
View reviewed changes
Comment thread Tools/c-analyzer/c_parser/preprocessor/clang.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@dg-pb
add experimental print
e6c8a85
@dg-pb

dg-pb commented May 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

In addition getting the following 2 errors:

Modules/socketmodule.c - netdb_lock not supported (typespec) static PyThread_type_lock

Python/bootstrap_hash.c py_getentropy getentropy_works not supported (mutable) static int
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dg-pb
included 2 failures to tsvs next to similar entries
09bf9b2
@dg-pb

dg-pb commented May 2, 2025

Copy link
Copy Markdown
Contributor Author

In addition getting the following 2 errors:

Modules/socketmodule.c - netdb_lock not supported (typespec) static PyThread_type_lock

Python/bootstrap_hash.c py_getentropy getentropy_works not supported (mutable) static int

Included these 2 into tsvs. Not sure why they were not failing in tests. Can only run clang, not gcc, so can not tell.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dg-pb added 2 commits May 2, 2025 06:52
@dg-pb
added fix/hack for curses.h fails
b28b686
@dg-pb
fix leftover from debug
7240988
@dg-pb

dg-pb commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

@ericsnowcurrently, any chance it would be possible to look into this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dg-pb
Merge remote-tracking branch 'upstream/main' into c_analyzer_clang_ex…
9784e82 
…perimental_preprocessor
@gpshead gpshead added the skip news label Nov 27, 2025
@gpshead
Merge branch 'main' into c_analyzer_clang_experimental_preprocessor
ed96942
@gpshead
gpshead enabled auto-merge (squash) November 27, 2025 22:01
@gpshead
gpshead merged commit 5ec03cf into python:main Nov 27, 2025
44 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting review label Nov 27, 2025
@dg-pb
dg-pb deleted the c_analyzer_clang_experimental_preprocessor branch November 27, 2025 23:15
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@dg-pb @StanFromIreland
pythongh-133228: c-analyzer clang preprocessor (pythonGH-133229)
a34a4a2 
* impl
* included 2 failures to tsvs next to similar entries
* added fix/hack for curses.h fails
* fix leftover from debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner AA-Turner left review comments
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

c-analyzer clang preprocessor

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@dg-pb @AA-Turner @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.